Sigma88 changed the topic of #Kopernicus to: #Kopernicus | Release 1.3.0-8 - https://git.io/v0Gg5 | Pictures: https://git.io/vHqLy | List of packs: http://git.io/vWjiY | GitHub: http://git.io/vWAFE | Examples: http://git.io/vWAF9 | Visual Editor: http://git.io/vWAbq | Funny Quotes: https://git.io/vHqt8 | <Kopernicus> Kopernicus/master 91e89a4 thomas-jenkins: Kopernicus 1.2.2-6 - "404 - Title not found"
Raidernick__ has joined #Kopernicus
Raidernick_ has quit [Ping timeout: 194 seconds]
ferram4_ has joined #Kopernicus
ferram4 has quit [Ping timeout: 202 seconds]
<Kopernicus> [Kopernicus] Corfiot commented on issue #300: Small note, this combination produced duplicates for karen and karen-orbit in the config, triggering an IOException in Kopernicus (multiple bodies, same name, see #302). Thus the scary warning and the OPM planets not loading. The pull request makes this config work as is on my machine with KSP1.4.5, without a newer version of SB. Haven't travelled to karen in-game but it seems to be there and the
<Kopernicus> [Kopernicus] Corfiot commented on issue #295: Maybe you should try again with the new release? https://git.io/fNrrw
<Kopernicus> [Kopernicus] Sigma88 commented on issue #300: There should be no duplicates using sb,... https://git.io/fNrFE
<Kopernicus> [Kopernicus] StollD commented on pull request #302 9371840: Since you already check for a duplicated body before the try / catch block starts, this could stay as it is right now. The logger shouldn't throw because of duplicated names anymore, so it doesn't need to be created in a try / catch. https://git.io/fNrxw
<Kopernicus> [Kopernicus] Corfiot commented on issue #302: The whole loading process seems to be aborted when a single log file fails to be created. This is why I covered it.... https://git.io/fNoR0
<Kopernicus> [Kopernicus] StollD commented on issue #302: Then please declare the bodyLogger variable outside of the try / catch but assign it inside. That way, the catch block can do a null-check on it and still log errors that are related to loading the body in the body log. https://git.io/fNozf
<Kopernicus> [Kopernicus] Corfiot commented on issue #302: The problem happened when the object was constructed not when it was set as active logger. Maybe we can create a simple constructor for it, then we can do as you suggest safely. https://git.io/fNo2d
<Kopernicus> [Kopernicus] StollD commented on issue #302: Or we just do this... https://git.io/fNoas
egg is now known as egg|sandwich|egg
<Kopernicus> [Kopernicus] Corfiot commented on issue #302: I'm not that good at C# yet, does a constructor that throw an exception set the instance to null?... https://git.io/fNooR
egg|sandwich|egg is now known as egg
<Kopernicus> [Kopernicus] StollD commented on issue #302: > I'm not that good at C# yet, does a constructor that throw an exception set the instance to null?... https://git.io/fNooK
<Kopernicus> [Kopernicus] Corfiot commented on issue #284: This is confirmed working on 1.4.5 with 1.4.5-1 with Outer Planets Mod. I didn't do any specific calculations but the power generation seems nominal. https://git.io/fNo6r
<Kopernicus> [Kopernicus] Corfiot commented on issue #302: Works exactly as before with less garbage collection, no null-checks and a smarter logger. https://git.io/fNoXG
<Kopernicus> [Kopernicus] StollD commented on issue #302: Looks good, thank you!... https://git.io/fNoXp
<Kopernicus> [Kopernicus] StollD closed pull request #302: Duplicate body/asteroid loader fix (master...duplicate-body-loader-fix) https://git.io/fNw77
<Qboid> Starting build #266 for job Kopernicus-Dev (previous build: SUCCESS)
<Qboid> Project Kopernicus-Dev build #266: SUCCESS in 23 sec: https://jenkins.tmsp.io/job/Kopernicus-Dev/266/
<Qboid> * gm: Duplicate body/asteroid loader fix
<Qboid> * gm: Consolidate loggers when loading bodies and asteroids
<Kopernicus> [Kopernicus] Corfiot commented on issue #302: Thanks for the feedback. https://git.io/fNo1L
egg is now known as egg|zzz|egg