egg changed the topic of #principia to: READ THE FAQ: http://goo.gl/gMZF9H; The current version is Cesàro. We currently target both 1.2.2 and 1.3. <scott_manley> anyone that doubts the wisdom of retrograde bop needs to get the hell out | https://xkcd.com/323/
<awang>
Something about that last commit appears to have broken the build for me
<GH>
[Principia] aw1621107 commented on issue #1573: I think this broke the build for me:... https://git.io/vdU1G
<egg|zzz|egg>
awang: hm yeah, phl screwed up
<egg|zzz|egg>
awang: can you make a pull request to put everything in barycentre_calculator_body.hpp in namespace internal_barycentre_calculator?
<egg|zzz|egg>
just open another layer of namespace at the beginning, close with a comment as the others
<egg|zzz|egg>
that should fix the compilation error
* egg|zzz|egg
should zzzleep
<GH>
[Principia] aw1621107 opened pull request #1575: Wrap barycentre_calculator_body in new namespace (master...fix-719417aa64013fe45b05bb386a80c3123efe228c) https://git.io/vdU1N
<awang>
Hmmm
<awang>
geometry/identity_test.cpp:55:19: error: qualified reference to 'Identity' is a
<awang>
constructor name rather than a type in this context
<GH>
[Principia] aw1621107 opened pull request #1578: Remove #pragma once from *.cpp (master...clobber-warnings/remove-pragma-once-from-cpp) https://git.io/vdUDY
<awang>
Is turning not_null<something> const loop variable into not_null<something> const& worth it?
<GH>
[Principia] aw1621107 opened pull request #1579: Add virtual destructor to Renderer (master...patch-1) https://git.io/vdUyk
uj8efdjkfdshf has joined #principia
<GH>
[Principia] aw1621107 opened pull request #1580: Turn loop variable copies to references (master...clobber-warnings/loop-variable-copies) https://git.io/vdUyC
MrSavage has quit [Remote host closed the connection]
awang has quit [Read error: Connection reset by peer]
awang has joined #principia
<GH>
[Principia] pleroy commented on issue #1580: Can one of the admins verify this patch? https://git.io/vdUN2
<GH>
[Principia] pleroy commented on issue #1575: Can one of the admins verify this patch? https://git.io/vdUNo
<egg|phone|egg>
Awang, not_null is just a pointer, so don't pass it by reference
<awang>
Ah, ok. Will fix
<awang>
Hold on, computer may crash
<awang>
Yay, it didn't
<GH>
[Principia] pleroy commented on issue #1575: Ah, of course, I missed that and the stupid Visual Studio didn't mind. Thanks for fixing. https://git.io/vdUNM
<awang>
If I make a change to a PR, would you prefer I make a new commit for the changes or force-push over the old changes?
<egg|phone|egg>
Awang, new commit
<egg|phone|egg>
We like commits
<egg|phone|egg>
And stupid commit messages
<awang>
Alright, just wanted to make sure
<awang>
Homebrew folks prefered the force-push method
<awang>
And I noticed the quality of your commit messages :P
<awang>
Very helpful when going through logs
<egg|zzz|egg>
yeah, some people like pull requests that are one commit and get rebased, we find that silly :-p
<egg|zzz|egg>
awang: hahaha
<egg|zzz|egg>
awang: btw, the "can one of the admins blah blah" spam is jenkins, it authenticates as phl because we're lazy
awang has quit [Read error: Connection reset by peer]
<egg|zzz|egg>
we should probably prefix the messages with "this is an automated message from the continuous build system"
<egg|zzz|egg>
uh oh
awang has joined #principia
<awang>
Sorry, kernel panic
<awang>
Are the only instances of not_null ones with explicit types?
<awang>
Or are some of the auto variables also not_nulls?
<awang>
Sort of makes me wonder too whether a pass that could turn references into copies for things like not_null would be valid
<egg|zzz|egg>
awang: a bunch of autos are not_nulls
<egg|zzz|egg>
awang: I *think* in ksp_resonance_test.cpp all are
<egg|zzz|egg>
but not sure
WetLemons has quit [Ping timeout: 198 seconds]
<egg|zzz|egg>
in pile_up.cpp they probably all are, too
<egg|zzz|egg>
planetarium.cpp I think so too?
<awang>
Might as well reject the PR then, since it looks like the vast majority of the changes I'm making are going to end up reverted :P
<egg|zzz|egg>
awang: nah, there are a bunch of valid changes
<awang>
Probably should try again with proper IDE support this time around
<awang>
Question is whether there are more valid changes than invalid changes
<egg|zzz|egg>
nah, the question is whether you can separate them
<egg|zzz|egg>
e.g. journal_proto_processor.cpp and apsides_test.cpp are clearly valid
<awang>
I probably can, just need to reboot into Windows to get Visual Studio up and running
<awang>
Since I don't think CLion support Visual Studio solutions
<awang>
And you don't have CMake set up
<egg|zzz|egg>
and I think ordinary_differential_equations_body.hpp is happy too
<egg|zzz|egg>
awang: maybe you could replace the other autos with not_null<whatever*> explicitly tbh, for consistency (pile_up.cpp has both that and auto...)
<awang>
Sounds like a good idea
<GH>
[Principia] eggrobin commented on issue #1580: As discussed on IRC, we don't use `not_null<T*> const&`, on the other hand we try to make those explicit rather than `auto`, precisely so we aren't tempted to add a `&`, so it might be a good idea to change those that use auto, for consistency (e.g., PileUp has both `auto const` and `not_null<Part*> const` for iterating on `parts_`. https://git.io/vdUAB
<awang>
If the parameter for not_null is T const*
<awang>
Should I use not_null<T const*> const?
<egg|zzz|egg>
not_null<T const*> const, yup
<egg|zzz|egg>
#define BADGER const
<egg|zzz|egg>
char BADGER* BADGER* BADGER
<awang>
Wait, that's legal?
<awang>
char const* const* const?
<GH>
[Principia] pleroy commented on issue #1575: ok to test. https://git.io/vdUAP
<egg|zzz|egg>
awang: sure, why not :-p
<egg|zzz|egg>
awang: btw, the continuous build takes 20-30 min lately, so this will take a while :D
<awang>
It's not like I'm in a hurry or anything, so it's all good
<GH>
[Principia] pleroy commented on issue #1576: ok to test https://git.io/vdUAH
<GH>
[Principia] pleroy commented on issue #1577: ok to test https://git.io/vdUAQ
<GH>
[Principia] pleroy commented on issue #1578: ok to test https://git.io/vdUA5
<GH>
[Principia] pleroy commented on issue #1579: ok to test https://git.io/vdUAd
<GH>
[Principia] pleroy commented on issue #1580: ok to test https://git.io/vdUAb
<GH>
Principia/master 7aea9c1 Alex Wang: Turn part.cpp loop var copies to refs
<GH>
Principia/master 0ba89bb Alex Wang: Turn ksp_resonance_test loop var copies to refs
<GH>
Principia/master 9ddd7ca Alex Wang: Turn ordinary_diff_eq_body loop var copies to refs
awang|zzz has quit [Ping timeout: 383 seconds]
egg|zzz|egg is now known as egg|tea|egg
uj8efdjkfdshf has quit [Quit: Connection closed for inactivity]
uj8efdjkfdshf has joined #principia
Rokker has joined #principia
<GH>
[Principia] pleroy opened issue #1581: Fix the remaining Clang warnings https://git.io/vdTGU
Jesin has quit [Quit: Leaving]
uj8efdjkfdshf is now known as TheCosmonaut
TheCosmonaut is now known as uj8efdjkfdshf
regex has joined #principia
regex has quit [Remote host closed the connection]
MrSavage has joined #principia
awang|zzz has joined #principia
awang|zzz has quit [Read error: Connection reset by peer]
awang has joined #principia
egg|tea|egg is now known as egg|nomz|egg
egg|nomz|egg is now known as egg
MrSavage has quit [Remote host closed the connection]
NolanSyKinsley has joined #principia
NolanSyKinsley has quit [Quit: Leaving]
Jesin has joined #principia
NolanSyKinsley has joined #principia
Jesin has quit [Quit: Leaving]
awang has quit [Read error: Connection reset by peer]
awang has joined #principia
LagrangianRaptor is now known as UmbralRaptor
WetLemons has joined #principia
uj8efdjkfdshf has quit [Quit: Connection closed for inactivity]
<egg>
awang: if you want to do more clang warning stuff, #1581 tracks the remaining interesting ones
<Qboid>
[#1581] title: Fix the remaining Clang warnings | A list of interesting warnings that we probably want to fix (not necessarily complete because sifting through the logs is hard):... | https://github.com/mockingbirdnest/Principia/issues/1581
Hypergolic_Skunk has quit [Quit: Connection closed for inactivity]
<GH>
[Principia] eggrobin commented on issue #1581: I don't think we want to fix `Wgnu-zero-variadic-macro-arguments` in `INSTANTIATE_TEST_CASE_P`. https://git.io/vdTrh
Asymptote has quit [Read error: Connection reset by peer]
Jesin has joined #principia
awang has quit [Read error: Connection reset by peer]