VITAS changed the topic of #spacedock to: Problems?: https://github.com/KSP-SpaceDock/SpaceDock/issues | Matrix/Riot Chat: https://im.52k.de +spacedock:52k.de Feel free to ask for help, we only bite a little bit! | If you want to help, please check https://github.com/KSP-SpaceDock/SpaceDock-Backend/issues/5 :) | <VITAS> inet users have the attentionspan of a squirrel...
VITAS[m] has joined #spacedock
<VITAS[m]> can we add a "reason for removal" of mod field i can fill out or even have the option of selecting from a dropdown of templates?
<VITAS[m]> (did i ask for that in the past? If not ill open an issue on GH)
<VITAS[m]> KineticSloth8StoneBlue: got the req for removal of the starwars mod and acted uppon it
<VITAS[m]> btw bonus points for "auto mail reason to uploader on removal of mod"
DasSkelett[m] has joined #spacedock
<DasSkelett[m]> We have that for mod locking. Both a reason field which is visible to the author, and an automated mail sent out to the author when a mod is locked.
<DasSkelett[m]> Not sure how we could add that for mod removal, since the mods are completely removed from the database as of right now, so nowhere to save the reason text...
VITAS[m] has quit [Quit: Idle timeout reached: 10800s]
KineticSloth8StoneBlue[m has joined #spacedock
<KineticSloth8StoneBlue[m> mebbe for mods to be deleted, DONT delete them right away?... like hide/lock them, for a time, (mebbe 7 days, or 30 days)... then auto-delete from the database after that?
<KineticSloth8StoneBlue[m> that might give time also, for the lister to resolve the issue? vOv
<DasSkelett[m]> Yes, that's what VITAS initially wanted (minus the auto-delete), and what I have implemented here: https://github.com/KSP-SpaceDock/SpaceDock/pull/260
<DasSkelett[m]> The feature just has to be used now. Not sure what the benefits are for duplicating the logic for mod removals, which would also require a big redo of how the code deletes mods.
<DasSkelett[m]> Or maybe VITAS just forgot that this already exists ^^
<RockyTV> just change the delete mod function to lock it for a week or so
<DasSkelett[m]> Why???
<DasSkelett[m]> We have a locking function. Why should we change the deletion to do the same? What for?
<RockyTV> sorry, I forgot to complete the phrase. I meant, change the delete function to make it lock the mod for a week, notify the author, then after a week the mod gets nuked from the DB
<DasSkelett[m]> Again, why???
<RockyTV> > can we add a "reason for removal" of mod field
<DasSkelett[m]> Why??????? Can you please answer that question? For the third time, we have a locking function where you can enter an reason.
<RockyTV> oh I just read this line
<RockyTV> > Or maybe VITAS just forgot that this already exists ^^
<RockyTV> 😛
KineticSloth8StoneBlue[m has quit [Quit: Idle timeout reached: 10800s]
<RockyTV> DasSkelett[m], I was checking #316 and there's a problem https://github.com/KSP-SpaceDock/SpaceDock/pull/316
Github[m] has joined #spacedock
<Github[m]> https://github.com/KSP-SpaceDock/SpaceDock/pull/316 : [WIP] Add cascade delete constraints, allow users to delete their accounts
<RockyTV> how will we handle mods by deleted users?
DasSkelett[m] has quit [Quit: Idle timeout reached: 10800s]
DasSkelett[m] has joined #spacedock
<DasSkelett[m]> Well... there are different opinions on that. Implemented right now in the PR is that everything in the db linked to that user is deleted, and so is the folder of the user on the file system (that includes mod files).
Github[m] has quit [Quit: Idle timeout reached: 10800s]
DasSkelett[m] has quit [Quit: Idle timeout reached: 10800s]