politas changed the topic of #ckan to: CKAN - The Comprehensive Kerbal Archive Network - https://git.io/vgh4P | Code of Conduct: https://git.io/vgh4t | Please upgrade to v1.25.4 Kennedy - https://git.io/vgh4g | Indexing almost 400 modules for 1.5.1! | Please consider raising issues on Github, you may get a better response.
_whitelogger has joined #ckan
<ckanbot>
[CKAN] DasSkelett opened issue #2604: CKAN installs recommendations even if told otherwise on "Audit recommendations" https://git.io/fpSnF
<ckanbot>
[CKAN] DasSkelett opened pull request #2605: Fix spelling error of netkan-bot in close-old-support-tickets.pl (master...fixNetkanBotSpelling) https://git.io/fpSCe
<ckanbot>
[CKAN] HebaruSan commented on issue #2604: I think it's because I used `DefaultOpts` to start the installation here:... https://git.io/fpSCV
politas_ has joined #ckan
politas has quit [Ping timeout: 183 seconds]
politas_ is now known as politas
<ckanbot>
[CKAN] HebaruSan opened pull request #2606: Don't auto-install recommendations when auditing recommendations (master...fix/audit-rec-opts) https://git.io/fpSl2
DasSkelett has quit [Quit: webchat.esper.net]
<ckanbot>
[CKAN] HebaruSan closed pull request #2605: Fix spelling error of netkan-bot in close-old-support-tickets.pl (master...fixNetkanBotSpelling) https://git.io/fpSCe
<ckanbot>
[CKAN] HebaruSan opened pull request #2607: Suppress wrapping of status bar (master...fix/status-bar-wrap) https://git.io/fpS05
mkv has joined #ckan
m4v has quit [Ping timeout: 180 seconds]
mkv is now known as m4v
_whitelogger has joined #ckan
m4v has quit [Ping timeout: 190 seconds]
m4v has joined #ckan
_whitelogger has joined #ckan
oeuf has quit [Read error: Connection reset by peer]
egg has joined #ckan
_whitelogger has joined #ckan
<ckanbot>
[CKAN] DasSkelett opened pull request #2608: Remove unnecessary parameter in Configuration methods (master...removeOldParam) https://git.io/fpSQO
<ckanbot>
[CKAN] DasSkelett commented on issue #2608: As I wrote this PR I was wondering if SaveConfiguration() shouldn't be private instead of public, this would force Save() to be called from outside, which I understood is the goal of having this separate function. https://git.io/fpSQg
<ckanbot>
[CKAN] HebaruSan commented on issue #2608: My rule of thumb: If you can make something private without breaking anything, do it. https://git.io/fpSQF
<ckanbot>
[CKAN] DasSkelett commented on issue #2608: That's a great rule of thumb :P https://git.io/fpS7v
<ckanbot>
[CKAN] DasSkelett commented on issue #2608: Okay, made it private, also LoadConfiguration(). This needed changing two tests to calling LoadOrCreateConfiguration() instead of LoadConfiguration(), but that doesn't affect their purpose. https://git.io/fpS5Y
<ckanbot>
[CKAN] DasSkelett commented on issue #2608: Okay, made it private, also LoadConfiguration(). This needed changing two tests to call LoadOrCreateConfiguration() instead of LoadConfiguration(), but that doesn't affect their purpose. https://git.io/fpS5Y
<ckanbot>
[CKAN] DasSkelett commented on issue #2608: Okay, made it private, also LoadConfiguration(). This needed changing two tests to call LoadOrCreateConfiguration() instead of LoadConfiguration(), but that doesn't affect their result. https://git.io/fpS5Y
<ckanbot>
[CKAN] DasSkelett commented on issue #2604: Ha! I forgot to write something in the issue, added now:... https://git.io/fpSFe
<ckanbot>
[CKAN] DasSkelett commented on issue #2604: Ha! I forgot to write something in the issue, added now:... https://git.io/fpSFe
<ckanbot>
[CKAN] DasSkelett commented on issue #2604: Ha! I forgot to write something in the issue, added now:... https://git.io/fpSFe
<ckanbot>
[CKAN] DasSkelett commented on issue #2608: Okay, made it private, also LoadConfiguration() (because we have LoadOrCreateConfiguration()). This needed changing two tests to call LoadOrCreateConfiguration() instead of LoadConfiguration(), but that doesn't affect their result. https://git.io/fpS5Y
<ckanbot>
[CKAN] DasSkelett commented on issue #2608: Okay, made it private, also `LoadConfiguration()` (because we have `LoadOrCreateConfiguration()`). This needed changing two tests to call `LoadOrCreateConfiguration()` instead of `LoadConfiguration()`, but that doesn't affect their result. https://git.io/fpS5Y
<ckanbot>
[CKAN] HebaruSan commented on issue #2604: I guess my question is, what would be the user intention behind doing that? If they intend to install the change set, I would think they would do that before messing with Audit recommendations.... https://git.io/fpSbL
<ckanbot>
[CKAN] DasSkelett commented on issue #2604: That's the 3rd option :)... https://git.io/fpSNm
_whitelogger has joined #ckan
<ckanbot>
[CKAN] HebaruSan commented on issue #2604: OK, third option added to the fix PR. We can change it later if someone presents a compelling case. https://git.io/fpSAk
BasharMilesTeg_ has joined #ckan
BasharMilesTeg has quit [Ping timeout: 183 seconds]