00:10
CommandoDiamond has joined #principia
00:41
Wetmelon has joined #principia
00:42
Moistmelon has quit [Ping timeout: 186 seconds]
00:49
LogBen has quit [Quit: WeeChat 1.4]
01:09
awang has quit [Ping timeout: 383 seconds]
01:22
awang has joined #principia
02:00
icefire has joined #principia
02:57
<
lamont >
heh now i’ve forgotten how to build Principia...
03:00
icefire has quit [Quit: Leaving]
03:02
<
lamont >
welp or it looks like it doesn’t compile on 10.12
03:02
<
lamont >
In file included from tools/generate_configuration.cpp:13:
03:02
<
lamont >
In file included from ./physics/solar_system.hpp:11:
03:02
<
lamont >
In file included from ./physics/continuous_trajectory.hpp:10:
03:02
<
lamont >
In file included from ./numerics/чебышёв_series.hpp:89:
03:02
<
lamont >
In file included from ./numerics/чебышёв_series_body.hpp:10:
03:02
<
lamont >
In file included from ./numerics/fixed_arrays.hpp:125:
03:02
<
lamont >
./numerics/fixed_arrays_body.hpp:122:46: error: use 'template' keyword to treat 'Row' as a dependent template name
03:02
<
lamont >
typename FixedMatrix<Scalar, rows, columns>::Row<r>
03:07
<
awang >
lamont: Fixed in master?
03:07
<
awang >
I submitted a PR, thought it was merged
03:15
<
lamont >
yeah the branch i’m trying to compile is behind master
03:15
<
lamont >
i’ll have to try to rebase
03:15
icefire has joined #principia
03:34
<
lamont >
ksp_plugin/interface_external.cpp:114:51: error: source file is not valid UTF-8
03:34
<
lamont >
if (manoeuvre_index >= flight_plan.number_of_man<9C>uvres()) {
03:35
<
lamont >
now that’s funny
03:40
<
awang >
lamont: That's a new one
03:40
<
lamont >
that’s in the code egg just wrote for me
03:45
icefire has quit [Read error: Connection reset by peer]
03:48
<
UmbralRaptor >
That's a reasonable error, especially from egg,
04:06
<
lamont >
yeah that was easy enough to figure out
04:06
<
lamont >
In file included from astronomy/solar_system_dynamics_test.cpp:28:
04:06
<
lamont >
In file included from ./testing_utilities/solar_system_factory.hpp:113:
04:06
<
lamont >
./testing_utilities/solar_system_factory_body.hpp:21:1: error: 'static' can only be specified inside the class definition
04:06
<
lamont >
static void SolarSystemFactory::AdjustAccuracy(
04:50
<
awang >
More MSVC noncompliance fun?
05:02
Mike` has quit [Ping timeout: 207 seconds]
05:07
Mike` has joined #principia
05:17
Wetmelon has quit [Ping timeout: 186 seconds]
05:25
CommandoDiamond_ has joined #principia
05:28
CommandoDiamond has quit [Ping timeout: 186 seconds]
06:17
NolanSyKinsley has quit [Remote host closed the connection]
06:32
CommandoDiamond_ has quit [Read error: Connection reset by peer]
07:42
Wetmelon has joined #principia
07:43
Hypergolic_Skunk has joined #principia
09:52
egg|laptop|egg has joined #principia
12:52
icefire has joined #principia
13:03
Hypergolic_Skunk has quit [Quit: Connection closed for inactivity]
13:33
<
GH >
[Principia] pleroy closed pull request #1704: Use polynomials to implement the continuous trajectories (master...ContinuousTrajectory)
https://git.io/vNFb6
13:53
NolanSyKinsley has joined #principia
14:51
<
GH >
[Principia] eggrobin opened pull request #1707: Report all failures (master...report-all-failures)
https://git.io/vNxUQ
15:45
<
egg|anbo|egg >
lamont: oh right I should have encoded the file as UTF-8. I'll fix that.
15:45
<
egg|anbo|egg >
lamont: aaand I'll fix the stray static I guess
16:19
<
GH >
[Principia] eggrobin opened pull request #1708: Remove stray static (master...static-out-of-line)
https://git.io/vNxYF
16:22
<
egg|anbo|egg >
lamont: the lamont-endpoints branch should have all your issues cleaned up now
17:23
<
GH >
[Principia] eggrobin commented on issue #1708: retest this please (a new kind of flakiness...)
https://git.io/vNxGo
17:35
<
egg|laptop|egg >
lamont: have you managed to call the thing successfully?
18:30
<
GH >
[Principia] pleroy opened pull request #1709: Filter out the medians from the benchmarks (master...Median)
https://git.io/vNxc9
18:31
<
GH >
[Principia] pleroy closed pull request #1708: Remove stray static (master...static-out-of-line)
https://git.io/vNxYF
18:31
<
GH >
Principia/master e5805ef Pascal Leroy: Merge pull request #1708 from eggrobin/static-out-of-line...
18:31
<
GH >
Principia/master e1e8d43 Robin Leroy: Fix a build error reported by lamont
18:32
<
GH >
[Principia] pleroy closed pull request #1707: Report all failures (master...report-all-failures)
https://git.io/vNxUQ
18:32
<
GH >
Principia/master fa06280 Robin Leroy: run all tests even if they die or fail
18:32
<
GH >
Principia/master 3b952f7 Robin Leroy: make a test crash and many tests fail
18:32
<
GH >
Principia/master 643cb5b Robin Leroy: Revert "make a test crash and many tests fail"...
18:35
<
lamont >
gotta wait for the coffee to settle this morning
18:39
<
egg|laptop|egg >
:D
18:49
stratochief_ has joined #principia
18:52
stratochief has quit [Ping timeout: 383 seconds]
19:11
stratochief_ is now known as stratochief
19:48
<
lamont >
In file included from tools/generate_configuration.cpp:13:
19:48
<
lamont >
In file included from ./physics/solar_system.hpp:12:
19:48
<
lamont >
./physics/continuous_trajectory.hpp:201:21: error: declaration of 'Frame' shadows template parameter
19:48
<
lamont >
template<typename Frame>
19:48
<
lamont >
./physics/continuous_trajectory.hpp:31:19: note: template parameter is declared here
19:48
<
lamont >
template<typename Frame>
19:48
<
lamont >
fatal error: too many errors emitted, stopping now [-ferror-limit=]
19:48
<
lamont >
6 warnings and 2 errors generated.
19:48
<
lamont >
make:
*** [obj/tools/generate_configuration.o] Error 1
19:48
<
lamont >
tried a rebase on origin/master and got the same
19:54
<
awang >
Yeah, it's erroring out in master
19:54
<
awang >
Not just egg's code
19:55
<
awang >
./physics/continuous_trajectory_body.hpp:285:53: error: use 'template' keyword to treat
19:56
<
awang >
'ReadFromMessage' as a dependent template name
19:56
<
awang >
There's that too
19:56
<
awang >
Polynomial<Displacement<Frame>, Instant>::ReadFromMessage<
19:56
<
awang >
Might be a bit tricker to solve that the other error?
19:56
<
awang >
Since this is in a place where the function is being used, instead of just the declaration
20:09
<
egg|laptop|egg >
lamont: awang: argh.
20:10
<
egg|laptop|egg >
awang: can you look into those, it's awkward for me to build on linux from here
20:10
<
egg|laptop|egg >
I could build on mac I guess, but then I'd have to open my corp laptop and I might end up working which I want to avoid on weekends
20:12
<
awang >
egg|laptop|egg: Sure
20:12
<
awang >
egg|laptop|egg: What do you want me to do with the shadowed template parameter?
20:12
<
awang >
I just added a trailing underscore to see if the rest would build
20:12
<
awang >
But idk what you'd normally do
20:13
<
awang >
The other one might require a bit of back and forth, like the last dependent template name thing
20:13
<
awang >
Since I don't have VS 2015 installed
20:13
<
awang >
Hey, a third one
20:13
<
awang >
physics/continuous_trajectory_test.cpp:106:3: error: missing 'typename' prior to
20:13
<
awang >
dependent type name 'P::Coefficients'
20:13
<
awang >
P::Coefficients const coefficients = {Displacement<Frame>(),
20:14
<
awang >
^~~~~~~~~~~~~~~
20:15
<
awang >
physics/continuous_trajectory_test.cpp:120:10: error: use of undeclared identifier
20:15
<
awang >
'degree_'; did you mean 'degree'?
20:15
<
awang >
return degree_;
20:15
<
awang >
Ah, last one is because degree_ is private
20:33
<
egg|laptop|egg >
awang: but the friend declaration should solve that?
20:34
<
awang >
egg|laptop|egg: Yeah, I see
20:35
<
awang >
idk what's going on
20:35
<
awang >
I had to change the template<typename Frame> part at least
20:35
<
awang >
Since template parameters can't shadow other ones
20:35
<
awang >
idk if that plays into it
20:35
<
egg|laptop|egg >
awang: try removing line 201 and saying friend class TestableContinuousTrajectory<Frame>
20:35
<
egg|laptop|egg >
awang: there should be no need for cross-frame friendship
20:35
<
awang >
Already tried that, Clang complained about trying to specialize a non-template class
20:36
<
egg|laptop|egg >
wah
20:36
<
awang >
./physics/continuous_trajectory.hpp:201:16: error: explicit specialization of
20:36
<
awang >
non-template class 'TestableContinuousTrajectory'
20:36
<
awang >
friend class TestableContinuousTrajectory<Frame>;
20:41
<
egg|laptop|egg >
O_o
20:42
<
awang >
I'm trying a forward declaration first now
20:43
<
egg|laptop|egg >
awang: forward-declare
20:43
<
egg|laptop|egg >
yeah
20:43
<
awang >
Want me to place it right above the friend declaration or at the top of the file?
20:44
<
egg|laptop|egg >
uh, above the class definition
20:45
<
egg|laptop|egg >
not inside it, that wouldn't declare the right thing
20:45
<
egg|laptop|egg >
(so above class ContinuousTrajectory)
20:45
<
egg|laptop|egg >
I should install clang for visual studio on this laptop, it works pretty well now
20:45
<
awang >
Do you prefer above or below the using declarations?
20:49
<
egg|laptop|egg >
below
21:13
<
awang >
Wrong channel >_>
21:13
<
awang >
Forward declaration didn't work
21:14
<
awang >
I'm a bit stumped
21:14
<
awang >
Unless you want to make degree_ protected
21:14
<
awang >
Which I'm guessing should be avoided
21:15
<
awang >
Pushed my work
21:16
<
awang >
Can you check to make sure I didn't do anything dumb?
21:16
<
awang >
Most recent 4 commits of that branch
21:51
<
GH >
Principia/master 47ee537 pleroy: Filter out the medians from the benchmarks.
21:51
<
GH >
Principia/master 58e59ba Pascal Leroy: Merge pull request #1709 from pleroy/Median...
22:17
<
egg|anbo|egg >
awang: use of undeclared identifier 'degree_age_'; unqualified lookup into dependent bases of class template 'TestableContinuousTrajectory' is a Microsoft extension
22:17
<
egg|anbo|egg >
all hail clang-cl
22:17
<
egg|anbo|egg >
awang: should be this->degree_age_ I think?
22:35
<
awang >
egg|anbo|egg: idk? I'm not familiar with that corner of C++
22:35
<
awang >
And my Clang didn't get that far
22:41
<
egg|laptop|egg >
awang: try this->degree_age_
22:41
<
egg|laptop|egg >
it will fix the thing
22:41
<
egg|laptop|egg >
(that's what clang-cl suggests, so it better fix it)
22:42
<
awang >
This is a different degree_
22:42
<
awang >
It's literally just degree_
22:44
<
GH >
[Principia] pleroy commented on issue #1677: #1611 was supposed to fix this "once and for all". Apparently it didn't.
https://git.io/vNx2B
22:45
<
egg|laptop|egg >
awang: yeah, same, this->degree_
22:45
<
egg|laptop|egg >
awang: there are a bunch of these, it's all the same problem
22:46
<
egg|laptop|egg >
you refer to something in a class which is not you (a friend or a base), and which is a template, therefore you need this->
22:46
<
awang >
One of the times Clang's venerable error messages have failed me
22:46
<
awang >
I didn't know that
22:46
<
egg|laptop|egg >
because the compiler can't know what your template friends or bases might contain until it sees the specialization
22:46
<
awang >
Haven't done enough deriving from/friending of template classes, apparently
22:47
<
egg|laptop|egg >
(all specializations)
22:47
<
egg|laptop|egg >
hah
22:47
<
awang >
Wonder if I should file a Clang bug, because the error message wasn't helpful
22:49
<
GH >
[Principia] eggrobin commented on issue #1677: It was supposed to fix it for the flight planner window, and as far as I know it did (once and for all!)....
https://git.io/vNx26
22:52
C_Z has joined #principia
22:52
C_Z has quit [Client Quit]
23:11
<
lamont >
Okay pardon my french, but Hamilton can take his Hamiltonians and cram them up his ass…
23:42
<
egg|anbo|egg >
lamont: what happened?