13:05 <Thomas> Hmm, only some changes and OpenDock should be able to handle multiple games

13:07 <Thomas> VITAS: Dunno if you saw it on Github, but would breaking compatibility with the current URLs and adding a redirect for the mod route (i.e. "/mod/<id>/<name>" gets redirected to "/<gameshort>/mod/<id>/<name>") be ok for you?

13:07 <VITAS> no i didnt

13:07 <VITAS> im ok with different urls if the old one redirect to them

13:08 <VITAS> +s

13:08 <Thomas> cool

13:09 <VITAS> the question is: do we want to be verbose or short?

13:09 <Thomas> Because passing the gameshort in the URL makes the JS way easier than getting it from the modid

13:09 <VITAS> or simply offer both (because we have to offer redirection anyways)

13:09 <VITAS> yes i know i had the same problem

13:10 <VITAS> but people can edit urls and that could lead to problematic results

13:11 <VITAS> https://c3goc.de/ <- only took me 12h to make (including admin panel, registration and everything)

13:11 <VITAS> it uses laravel and some addons. but the short timespan is impressive

13:17 <Thomas> Nice

15:35 <RockyTV> Thomas don't we use the old way?

15:35 <RockyTV> get game from mod?

15:35 <RockyTV> also o/

15:36 <Thomas> When we get the game from the mod, we have to run the mod request first, and then we can run the other ones. When we get the game from the URL, we can run all requests in parallel

15:36 <Thomas> o/

15:36 <RockyTV> uh that works

15:37 <RockyTV> I'm working on the edit page again (procrastination hits me hard)

15:43 <SpaceDock> [OpenDock] StollD opened pull request #3: Add a 404 handler (master...feature/404-page) https://git.io/vdAv2

15:44 <RockyTV> uh what the heck

15:45 <RockyTV> mod route doesn't work

15:45 <RockyTV> it's something in my side

15:46 <Thomas> what happens?

15:46 <RockyTV> when you click the mod thumbnail in the front page, it redirects to /mods/id/name and then redirects to not-found

15:47 <RockyTV> oh, gameshort is invalid

15:47 <RockyTV> wut

15:47 <RockyTV> I'll reinstall the db

15:53 <RockyTV> still not workign

15:54 <RockyTV> http://localhost:5000/api/mods/kerbal-space-program returns 2 mods

15:54 <RockyTV> /api/mods/kerbal-space-program/1 returns "gameshort is invalid

15:54 <RockyTV> /api/mods/kerbal-space-program/0 returns "the mod is not published"

15:57 <Thomas> have you tried to look at the db directly?

15:57 <RockyTV> no..

15:58 <RockyTV> will do that now

16:00 <RockyTV> it works

16:00 <RockyTV> they are working

16:00 <RockyTV> er, they are published and there*

16:01 <Thomas> what says their gameID?

16:01 <RockyTV> 1

16:01 <RockyTV> oh wait

16:01 <RockyTV> http://localhost:5000/api/mods/1/1 works

16:02 <RockyTV> gameshort doesn't

16:02 <Thomas> so somehow, the relation between mod and game doesnt work

16:02 <RockyTV> gameshort doesn't work for that route, can you confirm?

16:03 <Thomas> I dont have an SDB setup atm

16:03 <Thomas> sorry

16:04 <Thomas> But I have an idea how to fix it

16:04 <RockyTV> uh I think we have to change some code in SDB

16:04 <RockyTV> app.Database.Where("short = ?", gameshort).Or("id = ?", cast.ToUint(gameshort)).Find(game)

16:04 <RockyTV> try casting to int first then fallback to string

16:05 <RockyTV> s/int/uint

16:05 <Qboid> RockyTV meant to say: try casting to uint first then fallback to string

16:05 <RockyTV> brb

16:06 <Thomas> There is no real need for a fallback, the gameshort should never be castable to an int

16:07 <Thomas> And the cast doesn't seem to be the problem, I think the relations are broken

16:11 <SpaceDock> [SpaceDock-Backend] StollD created fix-relations (+1 new commit): https://git.io/vdAfp

16:11 <SpaceDock> SpaceDock-Backend/fix-relations 83ad2ce Dorian Stoll: Try to fix relationship issues

16:43 <VITAS> Grand plan you have there

16:43 <VITAS> " Dorian Stoll: Try to fix relationship issues"

16:43 <Thomas> RockyTV: Can you check if it is still broken with the changes I made?

16:43 <Thomas> VITAS: :P

16:43 <VITAS> :D

16:43 <RockyTV> sure

16:54 <RockyTV> fixed it Thomas

16:54 <Thomas> awesome

17:01 <SpaceDock> [SpaceDock-Backend] StollD opened pull request #29: Try to fix relationship issues (master...fix-relations) https://git.io/vdAkU

17:02 <SpaceDock> [SpaceDock-Backend] StollD pushed 1 new commit to master: https://git.io/vdAkT

17:02 <SpaceDock> SpaceDock-Backend/master 43a0c94 Dorian Stoll: Merge pull request #29 from KSP-SpaceDock/fix-relations...

17:02 <Qboid> Starting build #77 for job SpaceDock-Backend (previous build: SUCCESS)

17:02 <SpaceDock> [OpenDock] StollD closed pull request #3: Add a 404 handler (master...feature/404-page) https://git.io/vdAv2

17:02 <SpaceDock> [OpenDock] StollD pushed 1 new commit to master: https://git.io/vdAkL

17:02 <SpaceDock> OpenDock/master ab6d5d8 Dorian Stoll: Merge pull request #3 from KSP-SpaceDock/feature/404-page...

17:04 <Thomas> Why the heck does spaceduck have my profile picture o.O

17:05 <Qboid> Project SpaceDock-Backend build #77: SUCCESS in 2 min 50 sec: https://jenkins.tmsp.io/job/SpaceDock-Backend/77/

17:05 <Qboid> Dorian Stoll: Try to fix relationship issues

17:06 <Thomas> well, fixed it

18:11 <RockyTV> uh

18:11 <RockyTV> mods still don't exist in opendock

18:11 <RockyTV> oh right

18:23 <VITAS> strange thing to say for a modhosting site

18:25 <RockyTV> Thomas is this normal?

18:26 <RockyTV> http://localhost:5000/api/games/kerbal-space-program/1 returns 404

18:40 <RockyTV> nvm

18:46 <RockyTV> need to fix css in edit page: https://sr.ht/qU1e.png