03:51 <ckanbot> [CKAN] phardy opened pull request #2341: Fix building on macOS (master...fix-macos-build) https://git.io/vA9x9

04:08 <ckanbot> [CKAN] HebaruSan commented on issue #2341: Still works for me on Ubuntu. :+1: ... https://git.io/vA9pO

04:10 <ckanbot> [CKAN] phardy commented on issue #2341: Got a build environment running today. Expect some updates to the wiki shortly too. :)... https://git.io/vA9pc

04:16 <ckanbot> [CKAN] HebaruSan commented on issue #2341: Cool! Issues you might be fixing by doing that, for future reference: #760, #1334, #2272. https://git.io/vA9pu

05:29 <ckanbot> [CKAN] politas commented on issue #2337: So we are allowing mod authors to destroy the integrity of their release version numbers?How do our users know which revision of a given mod release they have installed? Could we force an extra version level when we do this somehow? https://git.io/vA9hy

05:30 <ckanbot> [CKAN] politas commented on issue #2337: So we are allowing mod authors to destroy the integrity of their release version numbers?How do our users know which revision of a given mod release they have installed? Could we force an extra version level when we do this (similar to epochs, but automatic) somehow? https://git.io/vA9hy

05:49 <ckanbot> [CKAN] politas pushed 2 new commits to master: https://git.io/vA9jm

05:49 <ckanbot> CKAN/master 6b14299 Paul Hebble: Don't assume path is always longer than root

05:49 <ckanbot> CKAN/master f45d014 Myk: Merge #2332 Fix ArgumentOutOfRangeException when removing files from game root

05:49 <ckanbot> [CKAN] politas closed pull request #2332: Fix ArgumentOutOfRangeException when removing files from game root (master...fix/game-root-remove) https://git.io/vAPsx

06:09 <ckanbot> [CKAN] politas pushed 2 new commits to master: https://git.io/vA9jg

06:09 <ckanbot> CKAN/master 99f0417 Paul Hebble: Check conflicts and depends versions in sanity checks

06:09 <ckanbot> CKAN/master 5853e3f Myk: Merge #2339 Obey version properties of conflicts and depends relationships

06:09 <ckanbot> [CKAN] politas closed issue #2325: Conflict checking ignores "version" property https://git.io/vAKhZ

06:24 <ckanbot> [CKAN] politas pushed 2 new commits to master: https://git.io/vA9jQ

06:24 <ckanbot> CKAN/master 567fd17 Myk: Merge #2329 Improve CKAN.app launch script

06:24 <ckanbot> CKAN/master a523648 Paul Hebble: Simplify path handling, add Mono 5 path, alert on errors

14:13 <ckanbot> [CKAN] politas commented on issue #2341: Builds fine under Windows, too. https://git.io/vAHGo

14:14 <anaximander> hi all

14:14 <politas> o/

14:14 <anaximander> quick question from a first-time contributor - is there anything special I need to do to get CKAN building?

14:14 <anaximander> VS2017 on Win10

14:15 <anaximander> any prereqs, manual steps etc?

14:15 <anaximander> or is it just clone and go?

14:15 <ckanbot> [CKAN] politas closed pull request #2341: Fix building on macOS (master...fix-macos-build) https://git.io/vA9x9

14:15 <politas> Run the ./build.ps1 script from PowerShell rather than using VS build

14:16 <anaximander> gotcha

14:16 <anaximander> every time, or just first time?

14:17 <politas> That'll pull in all the pre-reqs and create a build_ subfolder with all the build artifacts, that you can blow away if you have any issues building later.

14:17 <politas> Every time. That way, you use the same build script that GitHub uses when we push code to the master branch

14:18 <anaximander> ah, that makes sense

14:18 <anaximander> I noticed there's an issue from a few weeks back regarding a TLS error on startup

14:19 <anaximander> the issue is resolved but when I run the latest CKAN I still get that

14:19 <politas> There may be some way to get VS to kick off the build properly, but I use monodevelop undser Linux primarily (as does HebaruSan and several other CKAN devs over the years)

14:19 <politas> You're running 1.24.0?

14:19 <anaximander> yeah, I'll have a poke around in VS; if there's a way to make VS build run that script instead I'll put a wiki page in for it

14:19 <anaximander> yep, downloaded a fresh copy of 1.24 this morning

14:20 <politas> Have you done the "click continue and refresh" step that HebaruSan has been telling everyone to do?

14:21 <politas> I have had some serious home network issues over the last few days, so haven't really gotten a handle on the workarounds.

14:21 <politas> It was all I could do to tidy up the branch status and push out a release.

14:21 <anaximander> yeah, it just logs that the connection to the master repo could not be established, and then hangs, gets greyed out, and Windows asks if I want to end the process

14:22 <anaximander> I figured I'd try building it from code in case there's anything new in there that might help, and if not, I could offer to lend a hand fixing it

14:22 <politas> Oh, if you could figure that out and write a wiki, I'd appreciate it! I'd love to be able to make use of VS debugging tools.

14:23 <politas> There are a few changes that may help with that, but have a read through the last few pages of the CKAN forum thread, because there have been a few people posting issues that have had workarounds posted for.

14:23 <anaximander> I'm a C# software engineer in my day job, so I figured I might be able to work something out ;)

14:24 <politas> Well, we would certainly welcome your expertise if you feel like helping out!

14:24 <anaximander> so yeah, after clicking to continue at the exception dialog and then clicking Refresh, the error it (eventually) gives is a nullref

14:24 <politas> My coding history is almost entirely procedural languages

14:25 <anaximander> parameter name: collection

14:25 <anaximander> which means it's probably iterating or LINQ-ing something that isn't there

14:25 <anaximander> likely whatever's supposed to come back from this web call it's failing to make

14:25 <anaximander> so that's where I'll start digging

14:26 <politas> Ah, crap. Travis, what did you do? (The build errored)

14:33 <politas> Have you got any experience working on code to work with high latency connections, by any chance?

14:38 <politas> Righto, bed time for me!

15:29 <anaximander> high-latency?

15:29 <anaximander> a little, actually

15:30 <anaximander> my last job, I was working on software that managed content downloads on embedded devices across a network that was known for being slow and prone to disconnection

15:31 <anaximander> had to do some clever things with variable wait times, smart retry, circuit-breaker pattern, that sort of thing

15:31 <anaximander> there's some handy libs for it on NuGet

18:25 <ckanbot> [CKAN] LadivItnas opened issue #2342: Could not find a part of the path 'C:\Users\name\Appdata\Local\Temp\CdFileMgr\02a3e06-bc35-40.json'. https://git.io/vAHzh

18:37 <ckanbot> [CKAN] HebaruSan commented on issue #2342: Interesting. Does this happen every time, or was it a one-off? Can you please check whether these folders exist?... https://git.io/vAHga

19:21 <ckanbot> [CKAN] LadivItnas commented on issue #2342: Yeah all of those folders exist https://git.io/vAHVI

19:21 <ckanbot> [CKAN] LadivItnas commented on issue #2342: Yeah all of those folders exist sorry for the late reply https://git.io/vAHVI

19:30 <ckanbot> [CKAN] HebaruSan commented on issue #2342: Thanks, what about C:\Users\name\Appdata\Local\Temp\CdFileMgr ? https://git.io/vAHV1

19:32 <ckanbot> [CKAN] LadivItnas commented on issue #2342: Oh no it's not there... https://git.io/vAHVA

19:49 <ckanbot> [CKAN] LadivItnas commented on issue #2342: How do I get it back there? https://git.io/vAHwM

19:53 <ckanbot> [CKAN] HebaruSan commented on issue #2342: That's quite strange! The Transactions library attempts to create that folder if it doesn't exist:... https://git.io/vAHwx

20:07 <ckanbot> [CKAN] LadivItnas commented on issue #2342: Creating the folder seems to have fixed it (even if it's empty)... https://git.io/vAHro

20:31 <Wetmelon> CKAN used to rebuild directory paths if they were missing. Has that been removed?

20:32 <Wetmelon> Specifically $ksp/Ships/VAB

20:32 <ckanbot> [CKAN] HebaruSan commented on issue #2337: I don't think "this is a new version but I used the same version number" is what happened here. The use case is that the original upload is _in error_ (in GPP's case, the KSP-AVC file), and it is replaced to fix that error. The author wishes to retract the original version of the upload. And if they manage it before the netkan bot gets around to their mod, they are in fact able to do so.... https://git.io/

20:40 <ckanbot> [CKAN] HebaruSan commented on issue #2337: I don't think "this is a new version but I used the same version number" is what happened here. The use case is that the original upload is _in error_ (in GPP's case, the KSP-AVC file), and it is replaced to fix that error. The author wishes to retract the original version of the upload. And if they manage it before the netkan bot gets around to their mod, they are in fact able to do so.... https://git.io/

20:40 <ckanbot> [CKAN] HebaruSan commented on issue #2337: I don't think "this is a new version but I used the same version number" is what happened here. The use case is that the original upload is _in error_ (in GPP's case, the KSP-AVC file), and it is replaced to fix that error. The author wishes to retract the original version of the upload. And if they manage it before the netkan bot gets around to their mod, they are in fact able to do so.... https://git.io/

20:43 <Wetmelon> Nope, it's still there https://github.com/KSP-CKAN/CKAN/blob/master/GUI/Main.cs#L379

20:51 <Wetmelon> wtf it works in my dev build lol

20:51 <Wetmelon> I literally just `git pull master` `cd CKAN; ./build

22:12 <politas> Hi Wetmelon, that sounds strange

22:18 <Wetmelon> Very :)

22:18 <Wetmelon> Are there any commits between the release and current master branch?

22:18 <Wetmelon> that could have affected that

23:00 <politas> Wetmelon: I don't believe so.

23:00 <politas> Sorry, been looking at https://github.com/KSP-CKAN/CKAN/pull/2337

23:00 <Qboid> [#2337] title: Invalidate stale cached files from GitHub in Netkan | ## Background... | https://github.com/KSP-CKAN/CKAN/issues/2337

23:06 <Wetmelon> yeah have fun with that :D

23:09 <ckanbot> [CKAN] politas commented on issue #2337: Yes, I agree that in this case, there would only be the new file being indexed, and no user would install the original zip file, but I'm thinking about future changes. In the past, we have tended to assume that a given URL is a specific file (and we negotiated with Sarbian in order to specifically achieve that for ModuleManager)... https://git.io/vAHSW

23:10 <Wetmelon> I have to admit I don't understand the problem

23:16 <politas> The problem is mod authors in-place modifying their release files.

23:16 <Wetmelon> And then you rehash, detect it, and move on?

23:17 <politas> But then how does the client know it needs to change it?

23:17 <politas> It's the same version, so it's not an upgrade

23:17 <Wetmelon> Doesn't matter, different hash.

23:18 <Wetmelon> I'd be inclined to simply BLOCK the download because it could be a compromised version

23:18 <Wetmelon> But other mod managers don't use versioning, they just use the hashes and assume it's legit

23:18 <politas> Which is what we do currently.

23:19 <Wetmelon> Where are the hashes stored / compared?

23:20 <politas> CKAN is more like software repository managers like apt than most mod managers

23:20 <politas> We store the hashes in the .ckan files.

23:23 <Wetmelon> politas: you need a "git push -force-with-lease" style upload lol

23:23 <ckanbot> [CKAN] HebaruSan commented on issue #2337: Users clearing their caches won't affect this; these changes affect netkan.exe only. The cache that we're purging is on the netkan bot server, which is the part of the architecture that's in charge of incorporating new files into the repository.... https://git.io/vAHSF

23:27 <Wetmelon> Actually I think that's my recommendation. Warn the author and reject the change

23:28 <Wetmelon> So users only see the originally indexed file

23:28 <Wetmelon> mm I guess that doesn't work if you're not caching locally though does it

23:31 <ckanbot> [CKAN] politas commented on issue #2337: Yes, I realise this PR is only handling the netkan side of things, but you're adding a new field into the .ckan files, which should be in the spec, and while this change is great for the specific case of an invalid download being replaced with a valid download, it's going to cause problems if a mod author changes a valid download to a new valid download. ... https://git.io/vAH93

23:32 <ckanbot> [CKAN] HebaruSan commented on issue #2337: I may have misunderstood; you're talking about possible future functionality to prompt users to reinstall the same version? I would picture this working by comparing a new `CkanModule.release_date` property to the already existing `InstalledModule.InstallTime` property, set when you install the module and not dependent on the cache.... https://git.io/vAH9C

23:32 <politas> Warning the author is unfortunately not possible