egg|zzz|egg changed the topic of #principia to: READ THE FAQ: http://goo.gl/gMZF9H; The current version is Clifford. We currently target 1.2.2, and 1.3.1. <scott_manley> anyone that doubts the wisdom of retrograde bop needs to get the hell out | https://xkcd.com/323/
<egg>
awang: do you think it's OK to release Coxeter for 1.3.1 & 1.2.2 only?
<egg>
we'd like to try building the release tomorrow
<egg>
of course that means we'd depend on RO not releasing for another month
<egg>
(we cannot allow a principia gap!)
<awang>
Are there significant C++ code changes required for 1.4.0?
<awang>
Or do you not want to worry about 1.4.0 support for now?
<awang>
If that, then sure
<awang>
RO's release is perpetually Soon (c)
<awang>
Don't think you need to worry about it releasing
<awang>
Especially with 1.4.0 dependency shenanigans
<awang>
And I'm somewhat tempted to see if 1.3.1 could be skipped
<awang>
Or at least have both a 1.4.0 and 1.3.1 release
Snoozee has quit [Quit: CUT THE HARDLINES!!]
Snoozee has joined #principia
Snoozee is now known as Majiir
<egg>
awang: I don't know, I thought you had managed to get it working with 1.4.x with minor changes?
<egg>
(there should never be C++ changes for that, it's all in the C# layer)
Hypergolic_Skunk has quit [Quit: Connection closed for inactivity]
<awang>
egg: Well, it compiles
<awang>
idk if it works
<awang>
Want a PR, or should I wait?
<awang>
*wait for 1.4.1?
<egg>
feel free to make a pull request, might be nice to try it out in game
<awang>
Alright
<egg>
when is 1.4.1 scheduled?
<awang>
Principia doesn't have any dependencies, right?
<awang>
I'm guessing Tuesday?
<awang>
KSP subreddit had a post from Squad about a livestream marathon Monday/Tuesday
<awang>
So I'm guessing it'll drop sometime during/shortly after that?
<awang>
I'm pretty sure I'm going to screw up the vsproj configuration
<GH>
[Principia] aw1621107 opened pull request #1750: Get ksp_plugin_adapter compiling with KSP 1.4.0 (master...add-ksp-1.4.0-compatibility) https://git.io/vAjx1
<awang>
Looks like the C++ build actually completes on macOS now
<awang>
Oh crap
<awang>
Don't merge taht
<GH>
[Principia] aw1621107 closed pull request #1750: Get ksp_plugin_adapter compiling with KSP 1.4.0 (master...add-ksp-1.4.0-compatibility) https://git.io/vAjx1
<GH>
[Principia] aw1621107 commented on issue #1750: I'm stupid and forgot to switch branches before recompiling :( https://git.io/vAjxj
<egg>
awang: eh, just merge master back into this and reopen
<GH>
[Principia] aw1621107 opened pull request #1751: Get ksp_plugin_adapter compiling with KSP 1.4.0, take 2 (master...add-ksp-1.4.0-compatibility) https://git.io/vAjpi
<awang>
Aright, I think this one should be fine
<egg>
awang: .... why make two pull requests
<egg>
you could just have merged stuff into the first one...
<awang>
Uh
<awang>
Good question
<awang>
I panicked?
<egg>
poor 1750
<awang>
Sorry >_<
<egg>
awang: clearly you should find another unrelated change to rebase into 1750 and reopen it :-p
<egg>
awang: anyway, check that things do work with 1.4.0 in game, I'll review the thing tomorrow
<awang>
egg: Don't tempt me :P
<awang>
Yeah, I'll get it booted up once the C++ side finishes compiling
<egg>
awang: eh, I wouldn't mind if you put something into 1750, just rename it accordingly :-p
<awang>
lol
<awang>
Hijacking the PR?
<awang>
idk if that would work since I can't rename the branch once the PR is made
<awang>
I think
<egg>
you can rename the pull request
<awang>
Also, the linker problem with the C++ test binary seems to be something to do with Clang 5.0.0 LTO
<egg>
the linker problem was a bug that we fixed today
<egg>
(and don't build with Release_LLVM, that's experimental)
<awang>
The download page appears to be slightly broken
<egg>
awang: build with MSVC using VS2015, that is the only thing that is supposed to work
<egg>
and then check whether the adapter works with 1.4.0 on ma
<egg>
s/$/c
<Qboid>
egg meant to say: and then check whether the adapter works with 1.4.0 on mac
<awang>
Working on it
<awang>
Trying to figure out how to download VS 2015 first
<awang>
egg: VS 2015 *just* finished installing
<egg>
awang: so uh there's a deterministic null dereference if you turn on the engines apparently
<egg>
(we introduced that somewhat recently I think)
<awang>
egg: Wait what
<awang>
What engines?
<awang>
Like turn on rocket engines?
<egg>
yeah
<egg>
but possibly only when loading an old save
<egg>
we're investigating (this is a release blocker)
<awang>
Didn't happen to me when I tried out Principia on 1.4
<awang>
But that was a new save
<awang>
Also, you prefer to not use CMake for *nix builds, right?
<egg>
makefile only
<egg>
or fix bazelbuild/bazel#374 and transition to that
<Qboid>
[#374] title: Allow any characters in filenames | Ultimately any character can be part of a filename. We should probably allow that.... | https://github.com/bazelbuild/bazel/issues/374
<egg>
(I should take some time at work to fix it probably)
<awang>
That doesn't look fun to fix :(
* egg
works in i18n, so
<awang>
True
<awang>
Why bazel instead of cmake?
<awang>
Also, do I have to build using rebuild_all_solutions.ps1?
<awang>
Getting a compilation error, interestingly
<awang>
"Google/protobuf/vsprojects/Debug/js_embed.exe is not recognized as an internal or external command, operable program, or batch file"
<egg>
awang: hmm, do you have the latest protobuf from mockingbirdnest/protobuf
<egg>
we should have fixed that
<awang>
egg: git tells me I'm up to date
<awang>
Last commit Jan 20
<awang>
dc25c99?
<egg>
blarg
<egg>
I don't know
<egg>
I thought it worked here last time we tried
<awang>
Looks like js_embed.exe is in vsprojects/x64/Debug/
<awang>
VS is looking in vsprojects/Debug
<awang>
$(SolutionDir)$(Configuration)
<awang>
Is sthere something that should go in between for the arch?
<egg>
no
<awang>
Guess I can hack a solution by adding /x64/ in there
<egg>
hm
<egg>
or maybe $(Platform) but I think that doesn't work the same on win32
<egg>
I don't know just hack in an x64 and I'll look at it some other day
<egg>
why is everything broken :'(
<awang>
Guess I should open an issue?
<egg>
OK but do so in the principia repo
<egg>
so we track everything in one place
<awang>
Everything is broken because evidently watching us solve normal problems isn't amusing enough for the programming deities
<awang>
Alright
<awang>
Yay, more errors :(
<awang>
"Cannot open include file google/protobuf/unittest_no_arena_lite.pb.h: No such file or directory"
awang has quit [Ping timeout: 186 seconds]
awang has joined #principia
awang has quit [Ping timeout: 383 seconds]
<GH>
[Principia] pleroy opened pull request #1752: Capture by reference to fix an addressing fault (master...Crash) https://git.io/vxewz
<1APAABAWV>
[Principia] pleroy closed pull request #1752: Capture by reference to fix an addressing fault (master...Crash) https://git.io/vxewz
<5XYAAG7GS>
[Principia] pleroy pushed 2 new commits to master: https://git.io/vxeoF
<5XYAAG7GS>
Principia/master 464dcb7 pleroy: Capture by reference.