<SpaceDock>
[OpenDock] StollD pushed 2 new commits to master: https://git.io/v7gpt
<SpaceDock>
OpenDock/master 63abee8 Dorian Stoll: Working registration....
<SpaceDock>
OpenDock/master 7bfa1c7 Dorian Stoll: Mod featuring
<SpaceDock>
[SpaceDock-Backend] StollD pushed 1 new commit to master: https://git.io/v7gps
<SpaceDock>
SpaceDock-Backend/master 9198fc6 Dorian Stoll: Some fixes for OpenDock
<Qboid>
Starting build #71 for job SpaceDock-Backend (previous build: SUCCESS)
<Thomas>
VITAS: Hmm, we should be able to start a public test with OpenDock / sdb soon(tm). If you want that of course (I haven't forgot that you weren't the biggest fan of opendock :D)
<RockyTV>
"Edit and delete versions and view your mod as if you were not logged in"?
<RockyTV>
also, hi
<Thomas>
I am bad at descriptions :P
<Thomas>
I added the ability to edit versions, delete versions, and to view your mod like a normal user would see it (with all edit stuff removed)
<Thomas>
And hi
<SpaceDock>
[SpaceDock-Backend] StollD pushed 1 new commit to master: https://git.io/v72iA
<SpaceDock>
SpaceDock-Backend/master e58bdf7 Dorian Stoll: Set default mod version
<Qboid>
Starting build #73 for job SpaceDock-Backend (previous build: SUCCESS)
<SpaceDock>
[OpenDock] StollD pushed 1 new commit to master: https://git.io/v72ih
<SpaceDock>
OpenDock/master 709ff47 Dorian Stoll: Set default mod version
<Thomas>
RockyTV: Ok, the mod view page should do everything it is supposed to do now, except that the "Edit Mod" and "Update Mod" buttons, the outdated mod warning and the autoupdate don't work
Alanonzander has quit [Read error: Connection reset by peer]
Alanonzander has joined #spacedock
<SpaceDock>
[OpenDock] StollD pushed 1 new commit to master: https://git.io/v72Xm
<SpaceDock>
OpenDock/master c185c77 Dorian Stoll: Outdated mod warning
<VITAS>
bonus: you could incorporate the ability to add alpha, beta and release candidate game updates that dont outdate all mods and the same for mods so new ver of a mod isnt rated as the default one
<SpaceDock>
[OpenDock] StollD pushed 1 new commit to master: https://git.io/v72Sv
<SpaceDock>
OpenDock/master 20feadd Dorian Stoll: Working logout button
<Thomas>
VITAS: beta gameversions already exists
<Thomas>
and the outdated warning is built to ignore the newest betas
<VITAS>
yay
<VITAS>
and beta mod vers
<Thomas>
the fields are there but they do nothing
<Thomas>
my idea was that beta versions cant be marked as default and they have a special icon
<VITAS>
yes bnut how do you handle compatiblity with game versions
<Thomas>
(whoever made that black border deserves to be slapped :D)
<RockyTV>
svg icons are bugged
<RockyTV>
Thomas, can I use slim to request /api/mods/random and then trigger a redirect to /mods/id?
<Thomas>
sure
<RockyTV>
not sure if I should use default php, though (i.e. use php to request the json)
<Thomas>
RockyTV: Also, I figured out that the icons werent bugged in kerbal stuff, so I am currently going through the speed-hell of the internet archive :D
<RockyTV>
don't need to
<Thomas>
RockyTV: I think we can use php there
<Thomas>
I know that I dont need to but I like the F12 debugging window :D
<RockyTV>
nice, vs code has a in-editor merge conflict solver
<RockyTV>
do you need to be logged in to view a mod?
<RockyTV>
er "too many requests"
<RockyTV>
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at http://localhost:5000/api/users/current. (Reason: CORS header ‘Access-Control-Allow-Origin’ missing).
<RockyTV>
even with cors-blocking disabled in sdb
<Thomas>
Yeah, set a higher request limit
<Thomas>
I think 10 reqs per second isn't enough
<Thomas>
request-limit: "50-S" works for me
<RockyTV>
okay, random route works
<VITAS>
the round icons dont match the rest
<VITAS>
neither in form nor in color
<VITAS>
i suggest using button classes with only icons in them instead
<VITAS>
they wont be round but look better
<VITAS>
or you use my bendy css from the production site for those
<Thomas>
The interesting thing is that they looked good in kerbalstuff and I cant find the reason why they look bad now
<VITAS>
bootstrap?
<RockyTV>
uh Thomas I just realized we can do the random mod redirect with vue
<Thomas>
VITAS: We never updated in in the transition period
<RockyTV>
actually we did
<VITAS>
my i suggest to replace the random mod by mod suggestions powered by piwik?
<Thomas>
No, we updated it in opendock
<RockyTV>
we can have a box for that
<Thomas>
we never did for spacedock
<RockyTV>
ah
<VITAS>
newer bootstrap ver?
<RockyTV>
what version are we using? 3.6?
<VITAS>
anyway you can find it out using the inspector in your browser
<RockyTV>
Icon classes cannot be directly combined with other components. They should not be used along with other classes on the same element. Instead, add a nested <span> and apply the icon classes to the <span>.
<VITAS>
but the colors are different anyways
<RockyTV>
we do that, okay
<Thomas>
I know, and there are literally no differences between the kerbalstuff css and the open-/spacedock css
<VITAS>
and i remember that there was a bunch of additional css befor emine that battled with bootstrap
<VITAS>
i wouldnt use the ks css because it wasnt propper bootstrap
<VITAS>
and i would use bootstrap or not but not mix and fight it
<RockyTV>
I fixed the weird border in chrome
<SpaceDock>
[OpenDock] RockyTV pushed 5 new commits to master: https://git.io/v72F6
<SpaceDock>
OpenDock/master 88d819b Alexandre Oliveira: Use single quotes with path_for
<SpaceDock>
OpenDock/master 9ef125b Alexandre Oliveira: Add route for random mod
<SpaceDock>
OpenDock/master 1852f7c Alexandre Oliveira: Update glyphicons-halflings font
<RockyTV>
incoming commits
<RockyTV>
I didn't see the layout.html diff before adding :(
<RockyTV>
uh can sdb use ssl?
<Thomas>
sure
<Thomas>
not on its own, but through a proxy
<RockyTV>
hm
<VITAS>
how easy would it be to change the layout later?
<RockyTV>
you mean use a new frontend?
<VITAS>
e.g. if we want to replace prod with it and i want to use the current spacedock design?
<VITAS>
yes
<RockyTV>
you'd have to adapt it
<RockyTV>
and btw, not wanting to sound rude or anything, but if we keep working on opendock it'll end up more stable than current prod code
<VITAS>
i would welcome strict bootstrap as starting point
<VITAS>
it isnt rude
<VITAS>
anything is more stable
* VITAS
goes to bed
<Thomas>
I doubt that putting a new CSS onto the working opendock wouldn't be a problem for VITAS
<Thomas>
(he has done it already after all)
<Thomas>
RockyTV: Also, I have the feeling that the icons themselves arent centered
<RockyTV>
they aren't
<Thomas>
And all icons have different margins
<Thomas>
Arrgh
<Thomas>
I suggest font awesome :P
<RockyTV>
does it have all the icons we need?
<Thomas>
it has 3 times more icons than glyphicons
<RockyTV>
lets use it, then
<RockyTV>
we need to change our spans to <i>'s
<Thomas>
no, thats just the fontawesome example I think
<RockyTV>
You can place Font Awesome icons just about anywhere using the CSS Prefix fa and the icon's name. Font Awesome is designed to be used with inline elements (we like the <i> tag for brevity, but using a <span> is more semantically correct).
<RockyTV>
I think you meant the actual includes we have?
<Thomas>
Well, when we render / and /mods/1 we render two totally different files with different vue setups
<Thomas>
and in js we would need to do the same. The two pages must be different. and we need the ability to switch to a completely different vue setup
<Thomas>
and all that in JS which has a terrible garbage collection