Snoozee is now known as Majiir
politas has quit [Ping timeout: 200 seconds]
politas has joined #spacedock
Majiir is now known as Snoozee
politas has quit [Ping timeout: 186 seconds]
politas has joined #spacedock
<SpaceDock> [SpaceDock-Backend] StollD pushed 1 new commit to master: https://git.io/v7lBX
<SpaceDock> SpaceDock-Backend/master 127d068 Dorian Stoll: Rework the directory structure to work properly with glide etc.
<Qboid> Starting build #45 for job SpaceDock-Backend (previous build: STILL FAILING -- last SUCCESS #42 3 mo 0 days ago)
<SpaceDock> [SpaceDock-Extras] StollD pushed 1 new commit to master: https://git.io/v7lBM
<SpaceDock> SpaceDock-Extras/master a6c85cb Dorian Stoll: Path changes
<Qboid> Project SpaceDock-Backend build #45: STILL FAILING in 20 sec: https://jenkins.tmsp.io/job/SpaceDock-Backend/45/
<Qboid> dorian: Rework the directory structure to work properly with glide etc.
<Thomas> !tell RockyTV Could you push the glide stuff you have?
<Qboid> Thomas: I'll redirect this as soon as they are around.
egg|zzz|egg is now known as egg
Snoozee is now known as Majiir
SilverFox has quit [Ping timeout: 204 seconds]
<RockyTV> sure
<Qboid> RockyTV: Thomas left a message for you in #spacedock [30.07.2017 12:03:16]: "Could you push the glide stuff you have?"
<RockyTV> Thomas, do we commit .lock file?
<SpaceDock> [SpaceDock-Backend] RockyTV pushed 1 new commit to master: https://git.io/v7lPP
<SpaceDock> SpaceDock-Backend/master 57ddf14 Alexandre Oliveira: Setup Glide
<Qboid> Starting build #46 for job SpaceDock-Backend (previous build: STILL FAILING -- last SUCCESS #42 3 mo 1 day ago)
<Thomas> I would say yes
<Qboid> Project SpaceDock-Backend build #46: STILL FAILING in 6.1 sec: https://jenkins.tmsp.io/job/SpaceDock-Backend/46/
<Qboid> rockytvbr: Setup Glide
<RockyTV> why is jenkins still failing?
<RockyTV> oh, it's using activate.sh
<Thomas> Yeah
<Thomas> Umm
<Thomas> Can we use https cloning for github?
<RockyTV> yes
<RockyTV> I think
<RockyTV> let me check
<Thomas> because ssh clone is a bit annoying on windows
<RockyTV> yeah we can
<RockyTV> changing
<Thomas> \o/
<RockyTV> you need to change readme to reflect the changes you made to the directory structure
<Thomas> I already updated it
<SpaceDock> [SpaceDock-Backend] RockyTV pushed 1 new commit to master: https://git.io/v7lXU
<SpaceDock> SpaceDock-Backend/master cc04098 Alexandre Oliveira: Switch to https cloning for git packages
<Qboid> Starting build #47 for job SpaceDock-Backend (previous build: STILL FAILING -- last SUCCESS #42 3 mo 1 day ago)
<Qboid> Project SpaceDock-Backend build #47: STILL FAILING in 3.6 sec: https://jenkins.tmsp.io/job/SpaceDock-Backend/47/
<Qboid> rockytvbr: Switch to https cloning for git packages
<RockyTV> you didn't push it then
<RockyTV> okay I need to change something in glide
<SpaceDock> [SpaceDock-Backend] StollD pushed 1 new commit to master: https://git.io/v7lX3
<SpaceDock> SpaceDock-Backend/master 6163894 Dorian Stoll: Note to myself: push changes when you make them
<Qboid> Starting build #48 for job SpaceDock-Backend (previous build: STILL FAILING -- last SUCCESS #42 3 mo 1 day ago)
<Qboid> Project SpaceDock-Backend build #48: STILL FAILING in 3.5 sec: https://jenkins.tmsp.io/job/SpaceDock-Backend/48/
<Qboid> dorian: Note to myself: push changes when you make them
<RockyTV> I think we need glide.yaml in our gopath
<RockyTV> ah
<RockyTV> right
<Thomas> Worked for me. The only weird thing is that it thinks sdb depends on itself
<RockyTV> what do you mean?
<RockyTV> sdb.go?
<SpaceDock> [SpaceDock-Backend] RockyTV pushed 1 new commit to master: https://git.io/v7lXR
<SpaceDock> SpaceDock-Backend/master 3a634b0 Alexandre Oliveira: Update Glide package location
<Qboid> Starting build #49 for job SpaceDock-Backend (previous build: STILL FAILING -- last SUCCESS #42 3 mo 1 day ago)
<Qboid> Project SpaceDock-Backend build #49: STILL FAILING in 3.8 sec: https://jenkins.tmsp.io/job/SpaceDock-Backend/49/
<Qboid> rockytvbr: Update Glide package location
<RockyTV> there's no build_sdb.go file
<RockyTV> also, error: https://hastebin.com/ikutovivut.pl
<RockyTV> ah
<RockyTV> wait a minute
<SpaceDock> [SpaceDock-Backend] RockyTV pushed 1 new commit to master: https://git.io/v7lX1
<SpaceDock> SpaceDock-Backend/master 20fbbb1 Alexandre Oliveira: Fix build errors...
<Qboid> Starting build #50 for job SpaceDock-Backend (previous build: STILL FAILING -- last SUCCESS #42 3 mo 1 day ago)
<Qboid> Project SpaceDock-Backend build #50: STILL FAILING in 3.5 sec: https://jenkins.tmsp.io/job/SpaceDock-Backend/50/
<Qboid> rockytvbr: Fix build errors
<SpaceDock> [SpaceDock-Extras] StollD pushed 1 new commit to master: https://git.io/v7l1t
<SpaceDock> SpaceDock-Extras/master a95c968 Dorian Stoll: Build fix
<RockyTV> Thomas, what do you think of #27?
<Qboid> [#27] title: Move extra scripts to command-line arguments | If we actually end up restructuring our package, it might be good to retire the `tools/` directory and move the `migrate` and `setup` scripts to our main package. So, instead of calling them separately, they would be arguments passed to the main package.... | https://github.com/KSP-SpaceDock/SpaceDock-Backend/issues/27
<RockyTV> I'm already workign on it, just need your approval. I was thinking we'd need to move app.init() to a function and call it if we want to run the app
<Thomas> We should do that, yeah
<Qboid> Starting build #51 for job SpaceDock-Backend (previous build: STILL FAILING -- last SUCCESS #42 3 mo 1 day ago)
<Qboid> Project SpaceDock-Backend build #51: STILL FAILING in 3.5 sec: https://jenkins.tmsp.io/job/SpaceDock-Backend/51/
<Qboid> dorian: Fixes for the build scripts
<SpaceDock> [SpaceDock-Backend] StollD pushed 1 new commit to master: https://git.io/v7l1C
<SpaceDock> SpaceDock-Backend/master 9f958e0 Dorian Stoll: Fixes for the build scripts
<Thomas> Well, the nice thing about init is, that it loads everything you need for using sdb, even if you dont launch the server
<RockyTV> the problem is that init gets called on import
<RockyTV> and if we are going to set cmdline arguments, we can't have spacedock being loaded on import
<RockyTV> however, I think we'd need to change all of our init functions
<RockyTV> or just routes and app
<Qboid> Starting build #52 for job SpaceDock-Backend (previous build: STILL FAILING -- last SUCCESS #42 3 mo 1 day ago)
<Qboid> Project SpaceDock-Backend build #52: STILL FAILING in 2.6 sec: https://jenkins.tmsp.io/job/SpaceDock-Backend/52/
<RockyTV> GOOS=windows?
<Qboid> Starting build #53 for job SpaceDock-Backend (previous build: STILL FAILING -- last SUCCESS #42 3 mo 1 day ago)
<Qboid> Project SpaceDock-Backend build #53: STILL FAILING in 4.1 sec: https://jenkins.tmsp.io/job/SpaceDock-Backend/53/
<Thomas> Cross plattform compiling
<Thomas> RockyTV: Well, sdb had commandline args at some point (until I realized they were useless) all inside of the init function
<Thomas> We could load settings, and process them in Run()
<RockyTV> yeah
<Thomas> Because for example the setup script needs the spacedock environment
<RockyTV> just load the settings and actually load the db on run
<Thomas> for creating objects
<Thomas> I mean, sure, we can move stuff to run
<Qboid> Starting build #54 for job SpaceDock-Backend (previous build: STILL FAILING -- last SUCCESS #42 3 mo 1 day ago)
<Qboid> Project SpaceDock-Backend build #54: STILL FAILING in 8.7 sec: https://jenkins.tmsp.io/job/SpaceDock-Backend/54/
<Qboid> Starting build #55 for job SpaceDock-Backend (previous build: STILL FAILING -- last SUCCESS #42 3 mo 1 day ago)
<Qboid> Project SpaceDock-Backend build #55: STILL FAILING in 2.8 sec: https://jenkins.tmsp.io/job/SpaceDock-Backend/55/
<Qboid> Starting build #56 for job SpaceDock-Backend (previous build: STILL FAILING -- last SUCCESS #42 3 mo 1 day ago)
<Qboid> Project SpaceDock-Backend build #56: STILL FAILING in 1 min 0 sec: https://jenkins.tmsp.io/job/SpaceDock-Backend/56/
<Thomas> wow, it fails to find the plugins
<RockyTV> it gives me a pointer error
<RockyTV> idk why
<RockyTV> Thomas, you can clone SpaceDock-Extras to GOPATH
<Thomas> It seems that you try to access a database before a database exists
<Thomas> Or I fix the script that fetches the plugins with glide ;)
<RockyTV> clone it to /var/lib/jenkins/workspace/SpaceDock-Backend/src/github.com/KSP-SpaceDock/SpaceDock-Extras
<RockyTV> that works
<SpaceDock> [SpaceDock-Backend] StollD pushed 1 new commit to master: https://git.io/v7lMu
<SpaceDock> SpaceDock-Backend/master 538fa7c Dorian Stoll: Lets see if this works
<Qboid> Starting build #57 for job SpaceDock-Backend (previous build: STILL FAILING -- last SUCCESS #42 3 mo 1 day ago)
<RockyTV> uh where do I try to access a db before it exists?
<Thomas> I meant your stacktrace, but I am not sure
<Thomas> Can you pastebin your modifications to sdb.go (if there are any)?
<Qboid> Project SpaceDock-Backend build #57: STILL FAILING in 2 min 22 sec: https://jenkins.tmsp.io/job/SpaceDock-Backend/57/
<Qboid> dorian: Lets see if this works
<RockyTV> it fails on setting github commit status
<SpaceDock> [SpaceDock-Backend] StollD pushed 1 new commit to master: https://git.io/v7lMK
<SpaceDock> SpaceDock-Backend/master 3f8edc0 Dorian Stoll: Forgot one SpaceDock
<Qboid> Starting build #58 for job SpaceDock-Backend (previous build: STILL FAILING -- last SUCCESS #42 3 mo 1 day ago)
<Thomas> No it fails because I forgot a SpaceDock reference
<Thomas> RockyTV: Ok, so you moved the db init code from init to run, but the code that uses the db in the objects package is still in init
<Thomas> Because main imports the objects indirectly, objects.init gets called before app.Run
<Thomas> so you use the db before you create the connection
<Qboid> Project SpaceDock-Backend build #58: STILL FAILING in 2 min 59 sec: https://jenkins.tmsp.io/job/SpaceDock-Backend/58/
<Qboid> dorian: Forgot one SpaceDock
<Thomas> Hmm, almost got it
<Thomas> the windows version was successfull, but the second build had an error with build_sdb.go
<RockyTV> so what is the fix for the command-line argument change?
<RockyTV> also, what was wrong with build_sdb.go?
<SpaceDock> [SpaceDock-Backend] StollD pushed 1 new commit to master: https://git.io/v7lDY
<SpaceDock> SpaceDock-Backend/master 16c0b43 Dorian Stoll: the other version seems to duplicate the file somehow
<Qboid> Starting build #59 for job SpaceDock-Backend (previous build: STILL FAILING -- last SUCCESS #42 3 mo 1 day ago)
<Thomas> i think it contained sdb.go twice because the build script failed at deleting it
<Thomas> RockyTV: Tbh, I would keep everything in init, and just dont run the webserver if it isn't required. Even if the stuff we run (migration script) doesnt even use things like the database or the settings
<Qboid> Project SpaceDock-Backend build #59: STILL FAILING in 3 min 18 sec: https://jenkins.tmsp.io/job/SpaceDock-Backend/59/
<Qboid> dorian: the other version seems to duplicate the file somehow
<Thomas> 20:57:05 ERROR: No artifacts found that match the file pattern "sdb-*.zip". Configuration error?
<Thomas> 20:57:05 ERROR: ‘sdb-*.zip’ doesn’t match anything, but ‘src/github.com/KSP-SpaceDock/SpaceDock-Backend/sdb-*.zip’ does. Perhaps that’s what you mean?
<Thomas> I hate it xD
<RockyTV> Thomas, okay then
<Qboid> Starting build #60 for job SpaceDock-Backend (previous build: STILL FAILING -- last SUCCESS #42 3 mo 1 day ago)
<RockyTV> okay
<RockyTV> why does some log get bugged?
<RockyTV> (C:/Users/Alexandre/go/src/github.com/KSP-SpaceDock/SpaceDock-Backend/middleware/accessrestriction.go:80)
<Thomas> Color control codes
<Thomas> seems that your terminal cannot display them
<RockyTV> ah
<Qboid> Yippee, build fixed!
<Qboid> Project SpaceDock-Backend build #60: FIXED in 2 min 53 sec: https://jenkins.tmsp.io/job/SpaceDock-Backend/60/
<RockyTV> should I delete tools/ and move the contents to sdb.go or just import tools/?
<Thomas> Yippie
<Thomas> Import it
<Thomas> both files are rather large
<Thomas> and give that sdb.go gets processed on every build..
<Thomas> *given
<RockyTV> sdb.go:16:5: import "github.com/KSP-SpaceDock/SpaceDock-Backend/tools" is a program, not an importable package
<RockyTV> damn it
<RockyTV> fixed it
<Thomas> Lol, jenkins has a button that displays zip files as plaintext
<RockyTV> is it normal for the setup script to take a while to load
<RockyTV> s/load/finish
<Qboid> RockyTV meant to say: is it normal for the setup script to take a while to finish
<Thomas> Yes
<Thomas> Unless the app is set to debug mode it wont log
<Thomas> if it is set to debug mode it will log the heck out of your terminal :P
<RockyTV> uh question
<RockyTV> regarding the control codes: is it supposed to set my background color to blue?
<RockyTV> idk why but running sdb.exe evreytime will just update my database
<RockyTV> is it expected behavior
<RockyTV> ?
<Thomas> I am not sure what you mean
<Thomas> re control codes: could be
<RockyTV> everytime I run sdb.exe my terminal is spammed with "[2017-07-30 16:15:59] [2.63ms] INSERT INTO "role_abilities" ("ability_id","role_id") SELECT '16','2' WHERE NOT EXISTS (SELECT * FROM "role_abilities" WHERE "ability_id" = '16' AND "role_id" = '2')"
<Thomas> Ah, yeah. The abilities are defined in the routes, and it tries to create them when sdb starts
<RockyTV> can't you just check if they exist before trying to create them?
<Thomas> It does that
<Thomas> I think
<Thomas> Ah, I use FirstOrInit
<Thomas> That means "create if it doesnt exist"
<RockyTV> it generated a 40mb log file
<Thomas> and checking manually would spam even more
<RockyTV> hm,. the color codes might be messed up
<Thomas> Which terminal do you use?
<RockyTV> powershell
<Thomas> Hmm, works fine in powershell for me
<RockyTV> do you use colorhost?
<Thomas> what?
<Thomas> I use powershell
<RockyTV> my prompt sets the background color to black, though
<Thomas> the standard powershell that comes with win10
<RockyTV> don't you use modules?
<Thomas> No
<Thomas> And I see no control chars when I launch sdb, just this https://i.imgur.com/gtafwM3.png
<SpaceDock> [SpaceDock-Backend] StollD pushed 1 new commit to master: https://git.io/v7lS9
<SpaceDock> SpaceDock-Backend/master e7ad79e Dorian Stoll: Reduce startup spam
<Qboid> Starting build #61 for job SpaceDock-Backend (previous build: FIXED)
<RockyTV> isn't this save actually saving to the db?
<Thomas> No, because FirstOrInit already saves
<Thomas> So it was useless
<Qboid> Project SpaceDock-Backend build #61: SUCCESS in 2 min 11 sec: https://jenkins.tmsp.io/job/SpaceDock-Backend/61/
<Qboid> dorian: Reduce startup spam
<RockyTV> I'm trying to setup the command line flag for dummy data but it isn't working
<RockyTV> Thomas, where is the color code defined?
<Thomas> RockyTV: Dunno, somewhere in the stdlib i guess
<RockyTV> Thomas, do you think we should include run as a subcommand and if you run `sdb.exe` without subcommands/flags it prints help and exits?
<Thomas> RockyTV: I dont think that would be useful tbh
<RockyTV> we could add some overrides for settings if we end up adding run as a subcommand
<RockyTV> also, why does app print {$VERSION}?
<Qboid> [70758] title: Set migrate and setup scripts as subcommands by Alexandre Oliveira | Additions: 92 | Deletions: 9 | https://github.com/RockyTV/SpaceDock-Backend/commit/70758c66d917e505330221b3f16ff7d2ad1f0bcc
<RockyTV> oh
<RockyTV> I should submit it as a pr
<SpaceDock> SpaceDock-Backend/rockytv e44465e Alexandre Oliveira: Set migrate and setup scripts as subcommands...
<SpaceDock> [SpaceDock-Backend] RockyTV created rockytv (+1 new commit): https://git.io/v7lxZ
<RockyTV> shit
<RockyTV> I should rename the origin remote to upstream just so I don't push to upstream
<SpaceDock> [SpaceDock-Backend] RockyTV opened pull request #28: Set migrate and setup scripts as subcommands (master...rockytv) https://git.io/v7lxn
<SpaceDock> [SpaceDock-Backend] RockyTV force-pushed rockytv from e44465e to 4af9735: https://git.io/v7lxz
<SpaceDock> SpaceDock-Backend/rockytv 4af9735 Alexandre Oliveira: Set migrate and setup scripts as subcommands...
<RockyTV> k we can't use printf with \n
<RockyTV> otherwise it breaks build_sdb.go
SilverFox has joined #spacedock