VITAS changed the topic of #spacedock to: Problems?: https://github.com/KSP-SpaceDock/SpaceDock/issues | Matrix/Riot Chat: https://im.52k.de +spacedock:52k.de Feel free to ask for help, we only bite a little bit! | If you want to help, please check https://github.com/KSP-SpaceDock/SpaceDock-Backend/issues/5 :) | <VITAS> inet users have the attentionspan of a squirrel....oh a nut!
HebaruSan[m] has quit [Quit: Idle timeout reached: 10800s]
oeuf has quit [Read error: Connection reset by peer]
oeuf has joined #spacedock
aradapilot has joined #spacedock
<Micha> G'day
aradapilot has quit [Remote host closed the connection]
VITAS[m] has joined #spacedock
<VITAS[m]> hi
<VITAS[m]> youre alive :D
AllisTauri has joined #spacedock
allista[m] has joined #spacedock
<allista[m]> There should be a # before room name for it to be found; so much for context search =]
<allista[m]> VITAS: is pm alright to pass a key?
AllisTauri has quit [Quit: webchat.esper.net]
<VITAS[m]> not in discord
<allista[m]> I mean here, yes
<VITAS[m]> yes
allista[m] has quit [Quit: Idle timeout reached: 10800s]
AllisTauri[m] has joined #spacedock
<AllisTauri[m]> Nvm, found it
<AllisTauri[m]> How do I access THE irc? And which irc excaclty? It seems there's one at esper.net and the one at 52k.de where I don't know where to find the correct room... 🙃
VITAS[m] has quit [Quit: Idle timeout reached: 10800s]
aradapilot has joined #spacedock
aradapil_ has joined #spacedock
aradapilot has quit [Ping timeout: 190 seconds]
AllisTauri[m] has quit [Quit: Idle timeout reached: 10800s]
<DasSkelett> RockyTV and HebaruSan regarding amending/new commits: I agree with HebaruSan. #205 *definitely* should have been squashed before merge. Something like this really noises up the history, and you can't retrace what the ultimate goal of all those commits was easily, without looking at the PR. Or, if you want to test a new branch, and check wether this branch already includes a recently pushed commit to the upstream target branch, a simple `git
<DasSkelett> log --oneline -5` doesn't work.
<DasSkelett> There are cases where separate commits in one PR make sense (e.g. first commit is new API feature, second commit adjusts frontend, or something like this). But most of the time you are better off with just one commit, with a descriptive message and maybe even a description text. 10 'Fix formatting' and 20 'Fixed typo' commits in one PR without more details don't really make sense.
AllisTauri[m] has joined #spacedock
<AllisTauri[m]> Yea, and that single commit changes ALL the files in backend code and ALL the templates. So easy to follow 🤣
<AllisTauri[m]> Also, as far as I see, HebaruSan said nothing about squash.
<AllisTauri[m]> ...(truncated)
<AllisTauri[m]> Yea, and that single commit changes ALL the files in backend code and ALL the templates. So easy to follow 🤣
<AllisTauri[m]> Also, as far as I see, HebaruSan said nothing about squash.
<AllisTauri[m]> ...(truncated)
<RockyTV> repeated messages?
<RockyTV> AllisTauri[m], you're allista on github, right?
<RockyTV> what's your suggestion for this comment? https://github.com/KSP-SpaceDock/SpaceDock/pull/207#discussion_r309584443