VITAS changed the topic of #spacedock to: Problems?: https://github.com/KSP-SpaceDock/SpaceDock/issues | Matrix/Riot Chat: https://im.52k.de +spacedock:52k.de Feel free to ask for help, we only bite a little bit! | If you want to help, please check https://github.com/KSP-SpaceDock/SpaceDock-Backend/issues/5 :) | <VITAS> inet users have the attentionspan of a squirrel....oh a nut!
DasSkelett[m] has quit [Quit: Idle timeout reached: 10800s]
AllisTauri[m] has quit [Quit: Idle timeout reached: 10800s]
HebaruSan[m] has quit [Quit: Idle timeout reached: 10800s]
aradapilot has quit [Ping timeout: 190 seconds]
VITAS[m] has joined #spacedock
<VITAS[m]> ill check
<VITAS[m]> Request URL: https://alpha.spacedock.info/hook/
<VITAS[m]> Request method: POST
<VITAS[m]> ...(truncated)
<VITAS[m]> 404
AllisTauri[m] has joined #spacedock
<AllisTauri[m]> Yea, last slash should not be there
<VITAS[m]> k
<VITAS[m]> done
<VITAS[m]> last call
<AllisTauri[m]> Mm?
* VITAS[m] will on his way in a few mins
<AllisTauri[m]> Ah, I see. Good luck then!
<VITAS[m]> thx
AllisTauri[m] has quit [Quit: Idle timeout reached: 10800s]
aradapilot has joined #spacedock
aradapil_ has joined #spacedock
aradapilot has quit [Read error: Connection reset by peer]
aradapil_ has quit [Remote host closed the connection]
aradapilot has joined #spacedock
VITAS[m] has quit [Quit: Idle timeout reached: 10800s]
<RockyTV> is alpha updated?
AllisTauri[m] has joined #spacedock
<AllisTauri[m]> yes
<RockyTV> weird
<RockyTV> my PR didn't fix unpublished mods being displayed on a profile page
HebaruSan[m] has joined #spacedock
<HebaruSan[m]> Yours isn't deployed yet
<RockyTV> ah
VITAS[m] has joined #spacedock
* VITAS[m] found internet :D
DasSkelett[m] has joined #spacedock
<DasSkelett[m]> Oh then you can't be in Germany.
<VITAS[m]> iam
<VITAS[m]> but my club allready build something
<AllisTauri[m]> BTW, after all the fuss with autodeploy I started to think: why didn't we try to do it with jenkins/travis?
<RockyTV> gitlab CI/CD is awesome btw
<HebaruSa-> The /hook handler already existed
<AllisTauri[m]> Have you tried it again after the url fix? ^_^
<HebaruSa-> No, because I don't have code to simulate GitHub's secret/signature thing
<HebaruSa-> This looks promising though:
<HebaruSa-> $ curl -d '' https://alpha.spacedock.info/hook
<HebaruSa-> unauthorized
<HebaruSa-> Aug 10 16:57:16 sd6 gunicorn[4951]: 2019-08-10 16:57:16,712 WARNING flask.app:4955 No signature provided in the request
<HebaruSa-> Aug 10 16:57:16 sd6 gunicorn[4951]: 2019-08-10 16:57:16,716 WARNING flask.app:4955 X-Hub-Signature didn't match the request data
<AllisTauri[m]> You do, actually, you wrote it yourself for signature checking =)
<AllisTauri[m]> Ok, I'll test it with emulated push event
<HebaruSa-> I'd rather test against GitHub's actual hook code rather than my attempt to mimic it
<HebaruSa-> Anybody got some more code changes to push to alpha? ;)
<DasSkelett[m]> Well, if you ask for it, I have a few small changes.
<DasSkelett[m]> I will do a PR so you can have a look.
<HebaruSa-> Yes please!
<HebaruSa-> If this works then I think we are ready for the first PR from alpha -> beta
<RockyTV> DasSkelett[m], I think it would be better if you split it into 3 commits
Daz has quit [Read error: Connection reset by peer]
<RockyTV> use git add -p
<DasSkelett[m]> Will do
HebaruSan[m] has quit [Quit: Idle timeout reached: 10800s]
<HebaruSa-> Too many assumptions about how CKAN works are tightly coupled into SpaceDock
<HebaruSa-> SpaceDock developers should not have to know which function to call in which circumstance, they should have one simple access point
<RockyTV> AllisTauri[m], not sure if you noticed it but there's a method that fetches changes from github: https://github.com/KSP-SpaceDock/SpaceDock/blob/d9aa0742074d86a08390a4adf36f5ae5bfacc781/KerbalStuff/celery.py#L54
<HebaruSa-> He wrote that :)
<RockyTV> OH
<RockyTV> lol
<RockyTV> regarding send_to_ckan: are you sure CKAN doesn't create a PR for you if you send the create event?
<HebaruSa-> Yes
<HebaruSa-> notify_ckan goes here, which quits if there's no existing netkan: https://github.com/KSP-SpaceDock/SpaceDock-Notify/blob/master/app.py
<HebaruSa-> There's no code to call one from the other
<HebaruSa-> That would be a better design along the lines of a "single access point" as I mentioned earlier though
<RockyTV> I meant to say if ckan itself doesn't do that already?
<RockyTV> I think it does that automatically
<HebaruSa-> No, it doesn't. The only PR creation code is in that KSP-SpaceDock/SpaceDock-Notify project.
<HebaruSa-> This is one of the things I'd like to clean up longer-term between CKAN and SpaceDock.
<RockyTV> okay so here's what's happening
<RockyTV> when you create or edit a mod, the backend uses send_to_ckan
<HebaruSa-> Yes, via the web UI. Via the API, that appears to be missing.
<DasSkelett[m]> And if everything works out, the API should use `send_to_ckan()` now (after merge) too.
<RockyTV> I don't think it's possible to enable CKAN without using the web UI
<DasSkelett[m]> No it isn't
VITAS[m] has quit [Quit: Idle timeout reached: 10800s]
<HebaruSa-> The 'ckan' value from the request flows into the mod.ckan property in the db
<DasSkelett[m]> Ah sorry, it isn't possible _after_ creation
<HebaruSa-> Unless you just mean it's broken currently
<HebaruSa-> Oh
<DasSkelett[m]> *edit:* ~~No it isn't~~ -> ~~No it isn't~~
<RockyTV> wait
<RockyTV> it's easy to fix it
<DasSkelett[m]> I misread RockyTV's comment
<RockyTV> I was confused
<RockyTV> HebaruSa-, is it okay to merge DasSkelett[m] 's pr?
<HebaruSa-> I think so, yes. Would you like to do the honrs?
<RockyTV> sure
<RockyTV> mreged
<HebaruSa-> From the key lag on alpha I think something is happening!
<HebaruSa-> Aug 10 19:33:03 sd6 gunicorn[4951]: 2019-08-10 19:33:03,077 WARNING flask.app:4959 No signature provided in the request
<HebaruSa-> Aug 10 19:33:03 sd6 gunicorn[4951]: 2019-08-10 19:33:03,085 WARNING flask.app:4959 X-Hub-Signature didn't match the request data
<HebaruSa-> Wah wah :(
<HebaruSa-> VITAS, is the secret string set?
<RockyTV> :(
<HebaruSa-> I don't recall seeing confirmation of that yet
<HebaruSa-> I think we would only see "No signature provided in the request" if no secret was set
<RockyTV> is there a way to check what github is sending?
AllisTauri[m] has quit [Quit: Idle timeout reached: 10800s]
Daz has joined #spacedock
DasSkelett[m] has quit [Quit: Idle timeout reached: 10800s]
HebaruSan[m] has joined #spacedock
<HebaruSan[m]> Wow, my Unix friends program from 18 years ago was forwards-compatible with ipv6!
<HebaruSan[m]> ~HebaruSan/src/spy.c on alpha if anyone cares
DasSkelett[m] has joined #spacedock
<DasSkelett[m]> I feel observed.
<DasSkelett[m]> But it has nice colors!
<HebaruSan[m]> That thing was SO fun to write. I just read the source for familiar command line tools and found more efficient ways of cross referencing their data
<DasSkelett[m]> Oh wow. this even is properly documented!