egg has quit [Read error: -0x1: UNKNOWN ERROR CODE (0001)]
egg has joined #spacedock
DasSkelett[m] has joined #spacedock
<DasSkelett[m]>
I don't think we need a lot of handling of wrongly set configs. The only persons being able to change them are the server admins. They really should know themselves what to put there, including the type, and not rely on the code catching malformed input.
<DasSkelett[m]>
And they should know that they might have to update the config before pull or upstream merge if a hook is set up, IMHO this is the primary concern we have to worry about and solve in some way for SpaceDock.
<DasSkelett[m]>
The default values should only be something like a last fallback to prevent immediate crashes after a (auto-)pull, if possible at all. But again, the config should've been updated earlier.
<DasSkelett[m]>
The changes to the config are all visible in the config.ini.example.
<DasSkelett[m]>
We could create a checklist for the alpha>beta / beta>master PRs, including `Check the PR diff for changes in the config.ini.example and update the server's config.ini before merge if necessary`.
<DasSkelett[m]>
The checklist could be part of a new GitHub template for those PRs.
VITAS[m] has joined #spacedock
<VITAS[m]>
the ques tion is: how can we make it more automatic to deploy updates (even if there are config changes)
<VITAS[m]>
the code is only run by devs and on SD servers (i dont think therre are other sites runnign the soft)
<VITAS[m]>
we can think about SD and dont worry about others
AllisTauri[m] has joined #spacedock
<AllisTauri[m]>
Like i said: keep default config (not example) in the repo, add everything new to it, then merge it work the local config that will override anything environment specific. All stdlib, minimum code required
<VITAS[m]>
what he says
HebaruSan[m] has joined #spacedock
<HebaruSan[m]>
Unnecessarily complicated, especially for new contributors. config.ini.example is widely used in many projects.
<AllisTauri[m]>
*shrugging
<AllisTauri[m]>
Suit yourselves. I don't see anything complicated; instead of .example you have just the config. Everything else is in admin hands.
<AllisTauri[m]>
What we have now is pretty damn inconvenient. I have proposed a solution that costs nothing. But I understand that feng shui is always the most important thing in development.
<VITAS[m]>
you realize that you are "he" in my comment?
<AllisTauri[m]>
Obviously not ~_~'
<AllisTauri[m]>
I'm too tired apparently.
<AllisTauri[m]>
I'm sorry
<VITAS[m]>
then sleep :)
<AllisTauri[m]>
Need to put to sleep the little one first
<VITAS[m]>
do that you must
<VITAS[m]>
reead him some RFCs
<AllisTauri[m]>
)))
<AllisTauri[m]>
She's would appreciate. She's all for the rules.
<VITAS[m]>
maybe she will force others to finaly obey them and not setup slopy mailservers who cant even parse adresses with "+" in them
<AllisTauri[m]>
Was that the cause of missing registration confirmation emails?
<VITAS[m]>
my guess is celery is broken/stuck
<VITAS[m]>
havent checked it yet but thx for the reminder
<AllisTauri[m]>
Or redis.
<RockyTV>
AllisTauri[m], HebaruSan[m] DasSkelett[m] : why not force a fallback if the key doesn't exist? it will stop the app from crashing
<RockyTV>
> As noted above, it would not make sense for other projects using the codebase to have defaulted in links to this Discord
<RockyTV>
just do like every other entry in the config file, set it to a placeholder or set it empty, and the code won't complain about it
<AllisTauri[m]>
These defaults could be empty collections of corresponding types, or could contain mock URLs
<AllisTauri[m]>
Exactly
<VITAS[m]>
[MessageOK] 10.150.1.21 <support@spacedock.info> to: test32432.v@52k.de message ok [Welcome to SpaceDock] -> /usr/share/assp/notspam/Welcome_to_SpaceDock--18239.eml
<VITAS[m]>
so its getting trough to the mailproxy
<VITAS[m]>
but i get nothing
<VITAS[m]>
maybe because the address is local
<VITAS[m]>
if somneone could reg with a new mail address...
<VITAS[m]>
temp mail doh i could use that
<AllisTauri[m]>
There are services providing temporary mailboxes for testing and one-time secure communication
<VITAS[m]>
as i said: doh :D
<VITAS[m]>
working
<VITAS[m]>
disclaimer: i blindly restarted celery before testing
<VITAS[m]>
tried 3 tempmail services: all working
aradapilot has quit [Remote host closed the connection]
DasSkelett[m] has quit [Quit: Idle timeout reached: 10800s]
HebaruSan[m] has quit [Quit: Idle timeout reached: 10800s]
AllisTauri[m] has quit [Quit: Idle timeout reached: 10800s]
aradapilot has joined #spacedock
aradapilot has quit [Ping timeout: 190 seconds]
VITAS[m] has quit [Quit: Idle timeout reached: 10800s]