13:21 <discord-> e​gg. — @DRVeyl yes it does, of course; what are you trying to do

13:45 <discord-> e​gg. — @DRVeyl https://github.com/mockingbirdnest/Principia/search?utf8=%E2%9C%93&q=GetUniversalTime&type=

13:46 <discord-> B​utcher. — @egg I have a few changes to the Principia external API to allow other mods to read the flight plan, is that something you'd be interested in merging?

13:46 <discord-> B​utcher. — Mainly intended for use with kOS.

13:59 <discord-> e​gg. — I suppose this is https://github.com/mockingbirdnest/Principia/issues/2144?

14:01 <discord-> B​utcher. — Yes.

14:01 <discord-> e​gg. — that "not an exhaustive list" is scary, and that list seems essentially to be equivalent to exposing the internal flight plan API

14:01 <discord-> B​utcher. — In reality, I think it is just those.

14:02 <discord-> e​gg. — behave weirdly in the face of changes to the flight plan, e.g. out-of-order edition in the upcoming release

14:02 <discord-> B​utcher. — I have gone for read-only access rather than just throwing the API open.

14:03 <discord-> B​utcher. — Yes, that is a potential issue. Is there any uid for manoeuvres so you can check track the correct one?

14:03 <discord-> e​gg. — there's a sequential index; no unique ID

14:05 <discord-> e​gg. — it's probably best to discuss a well-defined design before starting to swim in the code; in any case if you want something in the external interface it needs documentation here https://github.com/mockingbirdnest/Principia/wiki/Interface-for-other-KSP-mods so you would have to properly define all the semantics eventually anyway

14:20 <discord-> B​utcher. — Is there a process for this?

14:22 <discord-> e​gg. — just discussion on the issue should work (compare e.g. https://github.com/mockingbirdnest/Principia/issues/1936)

14:23 <discord-> e​gg. — (https://github.com/mockingbirdnest/Principia/issues/1936 didn't really work out and we ended up doing it ourselves but that's a different question)

14:24 <discord-> B​utcher. — I have some changes I'm using locally, and they seem to work, but obviously, I'm just a single test case so possible not what others would want.

14:25 <discord-> B​utcher. — There seemed to be no interest / response at all to the github issue, so I assumed I was on my own here.

14:26 <discord-> e​gg. — well, we only have so much time, poking me on here is definitely a good idea too :-)

14:26 <discord-> D​amien. — poking or yolking?

14:26 <discord-> D​amien. — haha egg jokes, I crack myself up

14:29 <discord-> e​gg. — @Butcher Have a look at how https://github.com/mockingbirdnest/Principia/wiki/Interface-for-other-KSP-mods#geopotentialgetcoefficient defines things; you should similarly exhaustively define what your functions do, including error cases etc.; you probably want some sort of surrounding rationale so that it's clear that you have the functions you need and that there isn't a simpler and better approach

14:32 <_whitenotifier-5dfc> [Principia] RCrockford commented on issue #2144: Extending the external API to allow for interaction with flight planning - https://git.io/fjrRd

14:32 <discord-> B​utcher. — I've added some more detail.

14:33 <_whitenotifier-5dfc> [Principia] RCrockford edited a comment on issue #2144: Extending the external API to allow for interaction with flight planning - https://git.io/fjrRd

14:34 <discord-> e​gg. — "game space" <<< aaaaaa but there are two of those :-p

14:35 <discord-> e​gg. — (I think that's World though in this context so that's fine)

14:36 <_whitenotifier-5dfc> [Principia] RCrockford edited a comment on issue #2144: Extending the external API to allow for interaction with flight planning - https://git.io/fjrRd

14:36 <discord-> B​utcher. — Good catch, I have updated. 😉

14:38 <discord-> B​utcher. — It is essentially a summary of my local changes.

14:38 <discord-> B​utcher. — Changes are here: https://github.com/mockingbirdnest/Principia/compare/master...RCrockford:flight-planning-external-api

14:38 <discord-> e​gg. — > FlightPlanGetManoeuvreGuidance << that's at current time?

14:38 <discord-> e​gg. — > Magnitude of vector equal to required delta-V

14:38 <discord-> e​gg. — the total for the manoeuvre? what for?

14:39 <discord-> B​utcher. — Ideally yes, current time.

14:39 <discord-> B​utcher. — So you know how much deltaV you need?

14:39 <discord-> e​gg. — yeah but why bake it in that poor vector

14:39 <discord-> B​utcher. — Could have a separate function for dV and unit direction vector.

14:39 <discord-> e​gg. — yeah I think that would make more sense

14:40 <discord-> B​utcher. — Saves normalizing it.

14:43 <discord-> e​gg. — Anyway, this is reasonable well-defined; we'll try to find some time to review the design (bear in mind obviously that we're also rather busy with developing the mod itself so it may be a while)

14:43 <discord-> e​gg. — poke me if we forget

14:47 <_whitenotifier-5dfc> [Principia] RCrockford edited a comment on issue #2144: Extending the external API to allow for interaction with flight planning - https://git.io/fjrRd

14:50 <discord-> B​utcher. — Poke you in how long? A week, a month?

14:50 <discord-> e​gg. — left as an eggsercise to the reader

14:50 <discord-> e​gg. — speaking of poking, I should poke @Sir Mortimer with the word "mocks"

14:50 <discord-> B​utcher. — 😂

14:50 <discord-> B​utcher. — mocks?

14:51 <discord-> e​gg. — @Sir Mortimer wants to make UI mocks, which seems very useful

14:51 <discord-> e​gg. — although iirc that stuff is blocked on having screenshots of our UI or supporting 1.7.2, whichever one comes first

14:52 <discord-> e​gg. — I guess the new moon isn't too far away

14:52 <discord-> B​utcher. — Early July I think, the 4th maybe?

14:53 <discord-> e​gg. — https://github.com/mockingbirdnest/Principia/blob/e9d68968a5c4d839a0456629446d17526e21548b/ksp_plugin_adapter/main_window.cs#L10-L11

14:53 <discord-> e​gg. — ``` C#

14:53 <discord-> e​gg. — private readonly DateTimeOffset next_release_date_ =

14:53 <discord-> e​gg. — new DateTimeOffset(2019, 07, 02, 19, 16, 00, TimeSpan.Zero);

14:53 <discord-> e​gg. — ```

14:53 <discord-> e​gg. — https://github.com/mockingbirdnest/Principia/blob/e9d68968a5c4d839a0456629446d17526e21548b/ksp_plugin_adapter/main_window.cs#L10-L11

14:53 <discord-> e​gg. — ```C#

14:53 <discord-> e​gg. — private readonly DateTimeOffset next_release_date_ =

14:53 <discord-> e​gg. — new DateTimeOffset(2019, 07, 02, 19, 16, 00, TimeSpan.Zero);

14:53 <discord-> e​gg. — ``` (edited)

14:54 <discord-> e​gg. — https://github.com/mockingbirdnest/Principia/blob/e9d68968a5c4d839a0456629446d17526e21548b/ksp_plugin_adapter/main_window.cs#L10-L11

14:54 <discord-> e​gg. — ```cs

14:54 <discord-> e​gg. — private readonly DateTimeOffset next_release_date_ =

14:54 <discord-> e​gg. — new DateTimeOffset(2019, 07, 02, 19, 16, 00, TimeSpan.Zero);

14:54 <discord-> e​gg. — ``` (edited)

15:03 <discord-> B​utcher. — I was close.

19:31 <_whitenotifier-5dfc> [Principia] eggrobin reviewed pull request #2221 commit - https://git.io/fjrgD

19:31 <_whitenotifier-5dfc> [Principia] eggrobin labeled pull request #2221: Rewrite JacobiSNCNDN - https://git.io/fjrLu

19:57 <_whitenotifier-5dfc> [Principia] pleroy reviewed pull request #2221 commit - https://git.io/fjr2q

19:58 <_whitenotifier-5dfc> [Principia] pleroy synchronize pull request #2221: Rewrite JacobiSNCNDN - https://git.io/fjrLu

20:04 <_whitenotifier-5dfc> [Principia] Pending. Build queued… - 

20:04 <_whitenotifier-5dfc> [Principia] Pending. Building… - http://casanova.westeurope.cloudapp.azure.com:8080/job/Principia/3711/

20:33 <_whitenotifier-5dfc> [Principia] Success. Build finished. - http://casanova.westeurope.cloudapp.azure.com:8080/job/Principia/3711/

21:05 <_whitenotifier-5dfc> [Principia] pleroy closed pull request #2221: Rewrite JacobiSNCNDN - https://git.io/fjrLu

21:05 <_whitenotifier-5dfc> [Principia] pleroy pushed 5 commits to master [+0/-0/±6] https://git.io/fjra3

21:05 <_whitenotifier-5dfc> [Principia] pleroy ddbeba3 - Rewrite JacobiSNCNDN.

21:05 <_whitenotifier-5dfc> [Principia] pleroy c689760 - Remove TODO.

21:05 <_whitenotifier-5dfc> [Principia] pleroy e02eb3a - Some simplification.

21:05 <_whitenotifier-5dfc> [Principia] ... and 2 more commits.

21:07 <discord-> S​tandecco. — 1st of july here is going to be awesome

21:07 <discord-> S​tandecco. — exams over and principia release