Althego changed the topic of #KSPOfficial to: Kerbal Space Program official channel | versions: KSP1 1.12.2 bit.ly/ksp112update | Rules: tinyurl.com/KSP-Rules | "modcall" to call ops | Δv maps: https://i.imgur.com/CHVnEeE.pnghttps://i.imgur.com/gBoLsSt.png | Do not visit the hoverliths, for they carry a terrible curse.
wallacer has quit [Ping timeout: 192 seconds]
wallacer has joined #KSPOfficial
incon has joined #KSPOfficial
incon has quit [Client Quit]
bildramer has quit [Ping timeout: 189 seconds]
Wastl2 has joined #KSPOfficial
Wastl4 has quit [Ping timeout: 189 seconds]
bildramer has joined #KSPOfficial
sasamj has quit [Quit: Connection closed for inactivity]
sasamj has joined #KSPOfficial
Tank2333 has joined #KSPOfficial
Tank2333 has quit [Remote host closed the connection]
NicknameHere has quit [Quit: Connection closed for inactivity]
GlassYuri has quit [Read error: Connection reset by peer]
minas_tirith has quit [Remote host closed the connection]
minas_tirith has joined #KSPOfficial
hnOsmium0001 has quit [Quit: Connection closed for inactivity]
Althego has joined #KSPOfficial
Ezriilc has quit [Remote host closed the connection]
Lyneira has joined #KSPOfficial
sasamj has quit [Quit: Connection closed for inactivity]
minas_tirith has quit [Remote host closed the connection]
minas_tirith has joined #KSPOfficial
NicknameHere has joined #KSPOfficial
<Althego>
zombanwa
<darsie>
1339
<Althego>
eh
<sandbox>
1242
<Althego>
in the year 2525
<darsie>
If man is still alive
sasamj has joined #KSPOfficial
<Althego>
oh no, zombie is still on, ex-dragon is starting, and phoenix is incoming
Lyneira_ has quit [Quit: Bye]
<Althego>
kikkerikii
hnOsmium0001 has joined #KSPOfficial
wallacer has quit [Ping timeout: 192 seconds]
wallacer has joined #KSPOfficial
sasamj has quit [Quit: Connection closed for inactivity]
Tank2333 has joined #KSPOfficial
<umaxtu>
so I just reported a spelling error in a mod. Am I being a jerk for not figuring out how to fix it and submitting a pull request for a one line change? I did tell the mod author what file and line number the issue is on?
<raptop>
unsure
<umaxtu>
at least either way is better than the usual forum bug reports
<deadmind>
definitely better
<deadmind>
though it's a good excuse to figure out git and how to make a commit :)
<umaxtu>
I've done it once before. Just seems like a lot of hassle for a single line.
<flayer>
i think try to collect a bunch of spelling errors and submit a big report for them
<flayer>
but whatever
<deadmind>
umaxtu: maybe, but then again you've already done 98% of that effort
<deadmind>
if you used git to download the mod's source in the first place (which is just one command), and you edited the file to fix the typo on your machine anyway, you're literally about 10 seconds away from actually committing
<flayer>
i'm sleepy
<deadmind>
git add name of file, git commit -m "Commit message", git push
<deadmind>
that said, i've been meaning to add a small change to a mod i use a lot for like, 2 years :D
<umaxtu>
oh I was thinking I had to fork it, make the change their and then do a pull request
<umaxtu>
s/their/there
<deadmind>
it saves me three clicks on every spaceplane launch and i spent hours setting the tooling up so i can make the change, i made the change and it worked, but i'm too lazy to tidy it up and commit it lol
<deadmind>
umaxtu: that's still just one more step though
* deadmind
<- arguing against the laziness OF OTHERS since 1894
<raptop>
skip the arguments about laziness, I want to know your secret to longetivity
<deadmind>
i would tell you if only it didn't take so many words and letters
<raptop>
oh no
<deadmind>
i am not currently looking for that kind of commitment
* deadmind
fires up KSP to redundantly optimize his hyperspeed craft for zero benefit for the next 5 hours
* raptop
is sad that "git commit -crimes" is not valid
<bees>
git gud
<raptop>
git: 'gud' is not a git command. See 'git --help'.
<raptop>
The most similar command is add
<Izaya>
git makes 'git-command' work as subcommands like 'git command'
<Izaya>
and I'm pretty sure there'd be a program called git-gud