Sigma88 changed the topic of #Kopernicus to: #Kopernicus | Release 1.3.0-4 - https://git.io/v0Gg5 | Pictures: https://git.io/vHqLy | List of packs: http://git.io/vWjiY | GitHub: http://git.io/vWAFE | Examples: http://git.io/vWAF9 | Visual Editor: http://git.io/vWAbq | Funny Quotes: https://git.io/vHqt8 | <Kopernicus> Kopernicus/master 91e89a4 thomas-jenkins: Kopernicus 1.2.2-6 - "404 - Title not found"
NathanKell|AWAY is now known as NathanKell
Pap is now known as Pap|AFK
NathanKell is now known as NathanKell|Twitch
NathanKell|Twitch is now known as NathanKell|NOMZ
NathanKell|NOMZ is now known as NathanKell
NathanKell is now known as NathanKell|Twitch
NathanKell|Twitch is now known as NathanKell|AWAY
TonyAirborne has joined #Kopernicus
egg|zzz|egg is now known as egg|afk|egg
SigmaNomz is now known as Sigma88
<Sigma88> HAHAHAHAHAHA
<Sigma88> http://forum.kerbalspaceprogram.com/index.php?/topic/120111-13kopernicus-uncharted-lands-v053-02jun17/&do=findComment&comment=3113756
<Sigma88> KillAshley|SEMI: ^^^
ferram4 has quit [Ping timeout: 186 seconds]
<KillAshley|SEMI> lol wut
<KillAshley|SEMI> what a bug report ay
<KillAshley|SEMI> i honestly dont know where to begin when responding
TonyAirborne has quit [Ping timeout: 204 seconds]
<Sigma88> KillAshley|SEMI: I think my reply is enough :D
TonyAirborne has joined #Kopernicus
TonyAirborne has quit [Ping timeout: 200 seconds]
KillAshley|SEMI has left #Kopernicus [#Kopernicus]
KillAshley|SEMI has joined #Kopernicus
TonyAirborne has joined #Kopernicus
KillAshley|SEMI has left #Kopernicus [#Kopernicus]
KillAshley|SEMI has joined #Kopernicus
Pap|AFK is now known as Pap
Thomas|AWAY is now known as Thomas
<Sigma88> 0/ Thomas
<Thomas> \o
<Sigma88> did you see the link I sent KA?
<Sigma88> :D
<Thomas> yes
TonyAirborne has quit [Read error: Connection reset by peer]
<Sigma88> and did you have a chance to look at the landcontrol issue galileo was reporting?
<Sigma88> I couldn't see anything wrong in the logs
KillAshley|SEMI has quit [Ping timeout: 180 seconds]
KillAshley|SEMI has joined #Kopernicus
<Thomas> Sigma88: No, I only looked at the logs so far
<Sigma88> If you need some specific tests let me know
<Sigma88> thomas, maybe this can help you troubleshoot the issue
<Sigma88> I did a test and it seems it's somehow something that happens when parsing the cfg
<Sigma88> basically, I added an empty LandControl{} node in PQS/Mods
<Sigma88> and nothing changed
<Sigma88> I added landClasses{}
<Sigma88> and nothing changed
<Sigma88> I added a Class{ name = DesertGrounds }
<Sigma88> and in the kittopia export, the desertgrounds class was moved in last place
<Sigma88> and it lost all scatters definitions
KillAshley|SEMI_ has joined #Kopernicus
KillAshley|SEMI has quit [Killed (NickServ (GHOST command used by KillAshley|SEMI_))]
<Sigma88> now I'm trying to add the scatters definitions in the cfg
<Sigma88> to see if they are recovered
KillAshley|SEMI_ is now known as KillAshley|SEMI
<Thomas> Do you mean all classes suddenly lost their scatter?
<Sigma88> no
<Sigma88> just DesertGround
<Thomas> Ah wait, it is an existing class
<Sigma88> which is the only one I tried to patch
<Sigma88> yes
<Sigma88> and adding the scatters definitions in the parser didn't add them to the planet
<Sigma88> so it's most likely an issue with the collectionparser
<Sigma88> I would assume
<Sigma88> or the "Class" class itself
<Thomas> I can explain the first thing: Kopernicus always sets the landclass scatter, even if the list is empty
<Sigma88> but shouldn't it patch the existing one?
<Sigma88> instead of deleting it?
<Sigma88> and overwriting?
<Sigma88> it used to work like that
<Thomas> It never patched the class - scatter associations
<Thomas> it patched the class
<Sigma88> not sure what you meant
<Sigma88> s/nt/s
<Qboid> Sigma88 meant to say: not sure what you meas
<Sigma88> fudge
<Sigma88> "not sure what you mean"
<Sigma88> could you expand on that pls?
<Thomas> Well, Kopernicus supports patching the class
<Thomas> it does not support changing only some of the associations
<Thomas> either delete them or keep them
<Kopernicus> [Kopernicus] StollD pushed 1 new commit to master: https://git.io/vQodf
<Kopernicus> Kopernicus/master d316172 Dorian Stoll: Landclass Loader should only overwrite the associations if there are new ones
<Qboid> Starting build #94 for job Kopernicus-Dev (previous build: SUCCESS)
<Qboid> Project Kopernicus-Dev build #94: SUCCESS in 20 sec: https://jenkins.tmsp.io/job/Kopernicus-Dev/94/
<Qboid> dorian: Landclass Loader should only overwrite the associations if there are new
<Sigma88> let me test that
<Sigma88> love the irc link btw
<Sigma88> <3
<Thomas> all because of you breaking the build for weeks :P :D
* Thomas doesnt need amazon alexa, he just links his home into irc
<Sigma88> ok qboid, order me a pizza online
<Qboid> No
<Sigma88> fine
<Sigma88> Thomas: the new version works
<Thomas> Does it work with galileos config too?
<Sigma88> no idea
<Thomas> k
<Sigma88> should I link the archive in the issue?
<Sigma88> or would you rather me testing the cfg
<Sigma88> ?
<Thomas> Test the cfg please
<Thomas> Galileo cant access the build
<Sigma88> yes I know
<Thomas> Sigma88: .. I found the issue with the cfg
<Kopernicus> [Kopernicus] Sigma88 closed issue #179: Kopernicus not loading planets and requires reinstall https://git.io/vHWKN
<Thomas> Or rather with Kopernicus
<Thomas> All parser types need a [RequireConfigType] attribute
g^k_1^w^m_s^u has joined #Kopernicus
<Thomas> guess which parser type doesnt have it
g^k_1^w^m_s^u has left #Kopernicus [#Kopernicus]
<Sigma88> the one for scatters
<Sigma88> right?
<Thomas> Well, basicall all the parser types
<Thomas> but its only required in collection parsers
<Thomas> So I never notices
<Thomas> *d
<Sigma88> Thomas: using galileo cfg
<Sigma88> [LOG 17:16:27]: [Kopernicus]: Configuration.Loader: Failed to load Body: Kerbin
<Thomas> o.O
<Sigma88> galileo uses "removePQSMods"
<Sigma88> to remove landcontrol
<Sigma88> then adds a new landcontrol
<Sigma88> maybe that's a different issue?
<Thomas> Yeah, his config looks like a straight ripoff from the kittopia dump, lol
<Sigma88> it should work tho
<Sigma88> no ?
<Sigma88> from the error log it seems to me that kopernicus is trying to patch LandControl
<Sigma88> but since it can't find a LandControl, it fails
<Thomas> No, it has no problems loading it
<Thomas> there is something strange when it tries to load classes and scatters
<Sigma88> I edited the cfg
<Sigma88> removed all the nodes inside LandControl
<Sigma88> I kept only the values
<Sigma88> ok, that loads
<Sigma88> kerbin is all black
<Sigma88> :D
<Sigma88> now trying with classes but not scatters
<Sigma88> execption
<Sigma88> now trying with scatters but no landclasses
<Sigma88> could it be that the landclasses are pointing to scatters that are not created yet
<Sigma88> so it errors out because it can't find that specific scatter?
<Sigma88> scatters and no landclasses works fine
<Sigma88> I think that's the issue
<Sigma88> now I'm trying to store in the cfg scatters before landclasses
<Sigma88> nope
<Sigma88> I guess the kopernicus code loads classes before scatters
<Sigma88> you should switch them if this is the case
<Thomas> It loads classes before scatters but it applies the associations after loading everything
<Thomas> remember: This code has barely changed. it worked for years in its current form
<Sigma88> does the loading of a landclass that references a scatter require that scatter object to exist?
<Sigma88> btw, it doesn't load landclasses before
<Sigma88> it loads them after
<Sigma88> 931-935
<Thomas> That are just variables
<Sigma88> does that require a [RequireConfigType]
<Sigma88> ?
<Thomas> look at PostApply
<Kopernicus> [Kopernicus] StollD pushed 1 new commit to master: https://git.io/vQoAd
<Kopernicus> Kopernicus/master 05b6b8e Dorian Stoll: Add RequireConfigType everywhere
<Qboid> Starting build #95 for job Kopernicus-Dev (previous build: SUCCESS)
<Qboid> Project Kopernicus-Dev build #95: SUCCESS in 23 sec: https://jenkins.tmsp.io/job/Kopernicus-Dev/95/
<Qboid> dorian: Add RequireConfigType everywhere
<Sigma88> testing with this build
<Thomas> ahh, I think I know it. the landclasses are new, and class.scatters (the associations) is null. But I only apply the new list if anything was added to it (which didn't happen b/c RequireConfigType)
<Thomas> It is still unstable but it should work
<Thomas> Inb4 it doesnt works :P
<Sigma88> now it works
<Sigma88> at least, it loads the body
<Sigma88> and the kittopia dump looks fine
<Kopernicus> [Kopernicus] StollD pushed 1 new commit to master: https://git.io/vQoxE
<Kopernicus> Kopernicus/master 3c382eb Dorian Stoll: Check if the array is null. If yes, set it to an empty array so foreach works
<Qboid> Starting build #96 for job Kopernicus-Dev (previous build: SUCCESS)
<Qboid> Project Kopernicus-Dev build #96: SUCCESS in 20 sec: https://jenkins.tmsp.io/job/Kopernicus-Dev/96/
<Qboid> dorian: Check if the array is null. If yes, set it to an empty array so foreach
<Sigma88> now you just need to figure out the Kerbin cunundrum
<Sigma88> :D
<Sigma88> s/cun/con
<Qboid> Sigma88 meant to say: now you just need to figure out the Kerbin conundrum
<Sigma88> (planets using kerbin template mess up kopernicus)
<Thomas> I know
<Sigma88> and by "you need to" I mean "could you take a look? pretty please :D"
<Kopernicus> [Kopernicus] StollD pushed 1 new commit to master: https://git.io/vQopc
<Kopernicus> Kopernicus/master 0eb37ec Dorian Stoll: Try to fix the issue where multiple kerbins mess up everything
<Thomas> :P
<Qboid> Starting build #97 for job Kopernicus-Dev (previous build: SUCCESS)
<Sigma88> are you sure that fixes it?
<Sigma88> let me check
<Qboid> Project Kopernicus-Dev build #97: SUCCESS in 31 sec: https://jenkins.tmsp.io/job/Kopernicus-Dev/97/
<Qboid> dorian: Try to fix the issue where multiple kerbins mess up everything
<Thomas> No, I am not sure
<Thomas> Because SpaceCenter is a mess
<Thomas> It can kill itself on Awake
<Thomas> That means it will already happen in template loader
<Kopernicus> [Kopernicus] StollD pushed 1 new commit to master: https://git.io/vQopr
<Kopernicus> Kopernicus/master e23de9f Dorian Stoll: Keep the space centers alive
<Qboid> Starting build #98 for job Kopernicus-Dev (previous build: SUCCESS)
<Qboid> Project Kopernicus-Dev build #98: SUCCESS in 21 sec: https://jenkins.tmsp.io/job/Kopernicus-Dev/98/
<Qboid> dorian: Keep the space centers alive
<Thomas> If this doesn't work, I have no idea
<Sigma88> doesn't work
<Sigma88> would it be possible to clone laythe instead of kerbin? and then patch atmosphere, pqs and ocean from kerbin
<Sigma88> and finally patch the cfg on top of this?
<Sigma88> and clone kerbin only for the first planet that has "isHomeWorld = true"
<Sigma88> ?
<Sigma88> I think the issue occurs when cloning the kerbin template
regex has joined #Kopernicus
<Sigma88> Thomas: let me know if you want me to test anything in particular
ferram4 has joined #Kopernicus
egg|afk|egg is now known as egg
<Sigma88> thomas I have a coding question
<Sigma88> I have a class with a bunch of parameters
<Sigma88> and I have two classes that inherit that class
<Sigma88> each of those 2 new classes adds extra parameters
<Sigma88> when I create a new instance of the base class+
<Sigma88> I have made it so I can specify the values of the parameters
<Sigma88> so
<Sigma88> BaseClass oneBasicClass = new BaseClass(bool param1 = true, bool param2 = false, int param3 = 42);
<Sigma88> like that
<Sigma88> now, If I want to create a new instance of one of the inherited classes
<Sigma88> I can do
<Sigma88> InheritedClass myDerivedClass = new InheritedClass(bool param1 = true, bool param2 = false, int param3 = 42);
<Sigma88> how do I make it so I can generate a new Inherited class specifying all parameters (included the new ones that are specific of the inherited class) ?
<Sigma88> do I need to copy the whole code from the base class and add the new parameters? or is there a way to use the code from the base class, while adding some new stuff?
<Thomas> you can extend the constructor
<Thomas> public InheritedClass(bool param1, bool param2, int param3, string param4) : base(param1, param2, param3) { this.param4 = param4; }
<Sigma88> nice
<Sigma88> thanks
egg is now known as egg|nomz|egg
<Kopernicus> [Kopernicus] Avera9eJoe opened issue #193: Terrain scatter is broken in 1.3.0-4 https://git.io/vQK3P
<Kopernicus> [Kopernicus] StollD closed issue #193: Terrain scatter is broken in 1.3.0-4 https://git.io/vQK3P
TonyC2 has joined #Kopernicus
<Kopernicus> [Kopernicus] Sigma88 commented on issue #189: this issue should have been solved, if it passes some more tests it will most likely be included in the next release https://git.io/vQKsP
<Sigma88> thomas, when I create a new instance of a class with multiple optional parameters
<Sigma88> I can choose which ones to set
<Sigma88> right?
<Sigma88> so I could do
<Sigma88> Class test = new Class(param1 = true, param5 = false);
<Thomas> new Something(true, true, optionalParam1: false, optionalParam5: "donut")
<Sigma88> ah
<Thomas> Hah! We used the same numbers xD
<Sigma88> lol
<Sigma88> so I need to use :
<Sigma88> ?
TonyC1 has quit [Ping timeout: 186 seconds]
<Sigma88> instead of "="
<Thomas> Yes
<Kopernicus> [Kopernicus] StollD commented on issue #176: This will be in 1.3.0-5 https://git.io/vQKGO
<Kopernicus> [Kopernicus] Avera9eJoe commented on issue #189: Sounds good Sigma, Spectra will look a lot better with trees again! https://git.io/vQKWV
GregroxLaptop has joined #Kopernicus
<GregroxLaptop> o/
egg|nomz|egg is now known as egg
egg is now known as egg|zzz|egg
regex has quit [Remote host closed the connection]
GregroxLaptop has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client]
TonyC2 has quit [Ping timeout: 204 seconds]
UmbralRaptor is now known as CapitolRaptor
NathanKell|AWAY is now known as NathanKell
Pap is now known as Pap|AFK
NathanKell is now known as NathanKell|Twitch
egg|zzz|egg is now known as egg|df|egg
egg|df|egg is now known as egg|zzz|egg
NathanKell|Twitch is now known as NathanKell