Sigma88 changed the topic of #Kopernicus to: #Kopernicus | Release 1.3.0-6 - https://git.io/v0Gg5 | Pictures: https://git.io/vHqLy | List of packs: http://git.io/vWjiY | GitHub: http://git.io/vWAFE | Examples: http://git.io/vWAF9 | Visual Editor: http://git.io/vWAbq | Funny Quotes: https://git.io/vHqt8 | <Kopernicus> Kopernicus/master 91e89a4 thomas-jenkins: Kopernicus 1.2.2-6 - "404 - Title not found"
egg|z|egg is now known as egg|zzz|egg
GregroxMun has joined #Kopernicus
<GregroxMun> o/
GregroxMun has quit [Client Quit]
ferram4 has quit [Ping timeout: 383 seconds]
ferram4 has joined #Kopernicus
ferram4 has quit [Ping timeout: 200 seconds]
ferram4 has joined #Kopernicus
GregroxMun has joined #Kopernicus
<GregroxMun> sigma88
<GregroxMun> holy shit
<GregroxMun> seven of nine's reflection is the not-yet-assimiliated little girl
<GregroxMun> ok bye now
GregroxMun has quit [Client Quit]
<Sigma88> !tell Gregrox* lol
<Qboid> Sigma88: I'll redirect this as soon as they are around.
<Sigma88> thomas, online?
<Kopernicus> [Kopernicus] Sigma88 opened pull request #230: Sigma 1 (master...sigma-1) https://git.io/vdeO9
<Kopernicus> [Kopernicus] Sigma88 closed pull request #230: Sigma 1 (master...sigma-1) https://git.io/vdeO9
<Qboid> Starting build #136 for job Kopernicus-Dev (previous build: SUCCESS)
<Qboid> Project Kopernicus-Dev build #136: SUCCESS in 42 sec: https://jenkins.tmsp.io/job/Kopernicus-Dev/136/
<Qboid> * Sigma88: add an event I need for SB
<Qboid> * Sigma88: still adding the event
<Qboid> * Sigma88: allow to choose the psystembody of the loader
<Kopernicus> [Kopernicus] Sigma88 commented on issue #230: these changes are simple enough that I think there shouldn't be any problems in adding them... https://git.io/vdesI
<Kopernicus> [Kopernicus] StollD commented on issue #230: I don't know if I like that currentBody stuff to be honest...... https://git.io/vdesW
<Kopernicus> [Stellarator] StollD closed pull request #19: Better maps (master...BetterMaps) https://git.io/v5dv7
<Kopernicus> Stellarator/master ca7116c lajonat: Added biome generation - based on heightmap.
<Kopernicus> [Stellarator] StollD pushed 5 new commits to master: https://git.io/vdesg
<Kopernicus> Stellarator/master 4d41c2c lajonat: Create better texture maps - I noticed when creating bodies that aren't VertexPlanets, the texture map is completely blank....
<Kopernicus> Stellarator/master 80139b9 lajonat: Revert texture generation
<Kopernicus> [Stellarator] StollD pushed 5 new commits to master: https://git.io/vdes1
<Kopernicus> Stellarator/master 700ba35 lajonat: Merge remote-tracking branch 'origin/AddOceans'
<Kopernicus> Stellarator/master 2746ffc lajonat: Generate science values for each planet based on distance and stats
<Kopernicus> Stellarator/master 259f403 lajonat: Merge branch 'SetMoonAsKerbin'
<Kopernicus> [Stellarator] StollD closed pull request #21: Science values (master...ScienceValues) https://git.io/v5pRp
<SigmaBinary> [Sigma-Binary] Sigma88 opened pull request #36: Test (Development...test) https://git.io/vdesN
<SigmaBinary> [Sigma-Binary] Sigma88 closed pull request #36: Test (Development...test) https://git.io/vdesN
<Kopernicus> [KittopiaTech] StollD commented on issue #6: Added this feature https://git.io/vdeGT
<Kopernicus> [Kopernicus] Sigma88 commented on issue #230: gotcha https://git.io/vdeZO
<Kopernicus> [Kopernicus] Sigma88 commented on issue #230: can I change the generatedBody to be non-static? https://git.io/vdenj
<Kopernicus> [Kopernicus] Sigma88 commented on issue #230: I think this should do the trick... https://git.io/vdecY
<Kopernicus> [Kopernicus] Sigma88 commented on issue #230: alternatively we could use... https://git.io/vdecH
<Kopernicus> [Kopernicus] Laurentyb commented on issue #214: Im also currently experiencing this issue, with only GPP and Kopernicus, planetshine, scatterer. Panels face the wrong way, or face the right way but dont have any energy flow even with exposure at .99... https://git.io/vdeBZ
Rokker has quit [Quit: Connection closed for inactivity]
<Sigma88> thomas, is there a way to change the generatedBody thing without having to change all files in the project?
<Sigma88> I mean, if I change generatedBody to be non-static it would work
<Sigma88> but this would give problems
<Sigma88> I think it would be better to redefine how the PositionParser works
<Sigma88> because using "generatedBody" restricts you to use the parser only during the loading of that planet
<Sigma88> there are multiple ways to fix that, I'm not sure which one you would prefere
Rokker has joined #Kopernicus
<Sigma88> actually, it looks like my idea isn't working very well
<Kopernicus> [Kopernicus] Sigma88 opened pull request #231: Sigma 1 (master...sigma-1) https://git.io/vdePR
<Kopernicus> [Kopernicus] Sigma88 commented on commit ea87f41: the more I think about it, the more I think it would probably be better to just remove the radius completely, and let the vector 3 use only the altitude as input https://git.io/vdePQ
<Kopernicus> [Kopernicus] Sigma88 commented on issue #231: merging this for now,... https://git.io/vdeXQ
<Kopernicus> [Kopernicus] Sigma88 closed pull request #231: Sigma 1 (master...sigma-1) https://git.io/vdePR
<Qboid> Starting build #137 for job Kopernicus-Dev (previous build: SUCCESS)
<Qboid> Project Kopernicus-Dev build #137: SUCCESS in 38 sec: https://jenkins.tmsp.io/job/Kopernicus-Dev/137/
<Qboid> * Sigma88: option 1
<Qboid> * Sigma88: Revert "option 1"
<Qboid> * Sigma88: fix
<Kopernicus> [Stellarator] lajonat opened pull request #23: Missed one useTheInName (master...master) https://git.io/vde9w
egg|zzz|egg is now known as egg|nomz|egg
egg|nomz|egg is now known as egg
<Thomas> Sigma88: I would prefer if you wouln't merge pull requests that add actual features without giving me at least a chance to take a look at it (i.e. wait a day or two).
<Thomas> Bugfixes are ok
<Thomas> And o/
egg is now known as egg|tea|egg
egg|tea|egg is now known as egg
UmbralRaptor is now known as EigenRaptor
<Kopernicus> [Kopernicus] StollD commented on issue #230: I like your first suggestion, but I would suggest to make both, generatedBody and currentBody protected instead of public https://git.io/vdvkX
<Sigma88> Thomas: that's fine
<Sigma88> I only did it to get the compiled version off of jenkins to see if it was working as the one I compiled myself
<Thomas> ok
<Thomas> Sigma88: Btw, I had an even better idea https://hastebin.com/umerificab.cs
<Sigma88> yes that looks like what I wanted to do
<Sigma88> wait
<Sigma88> if I'm reading it correctly
<Sigma88> that would not allow me to do loader.currentBody = mybody;
<Thomas> no, but loader.generatedBody = mybody;
<Thomas> One var instead of two
<Sigma88> ah
<Thomas> But I dont want loader.generatedBody anyway, I want to do it with constructors
<Sigma88> what does "protected" mean?
<Thomas> That you can only access it if you extend the class
<Sigma88> ah
<Sigma88> so it's public but only in classes that are based on BaseLoader ?
<Thomas> replace public with accessable and I agree :)
<Sigma88> I don't know what the difference is :D
<Thomas> public = every class can access the member even if it isn't based on BaseLoader
<Thomas> protected = only this class can access it
<Sigma88> ah
<Thomas> for all other classes it is private
<Sigma88> interesting
<Thomas> .. what the heck is celestialBody.scaledEllipsoid
<Thomas> This sounds funny
<Sigma88> no idea
<Sigma88> is that 1.3.1?
<Sigma88> or 1.3.0
<Thomas> 1.3.0
* Thomas hasnt even downloaded 1.3.1 yet
<Sigma88> so thomas, how would anyone use that new syntax?
<Thomas> new XYLoader(myBody);
<Sigma88> ok, so I need to make a new definition for all the loaders?
<Sigma88> all those I want to use, I mean
<Sigma88> I was hoping for a solution that made all loaders able to do that automatically
<Kopernicus> [Kopernicus] Sigma88 opened pull request #232: Sigma 1 (master...sigma-1) https://git.io/vdvm0
<Thomas> I am going to do that. You dont need all loaders anyway (mod loader for example doesnt need it)
<Sigma88> yes I know, if I understand how this works I don't even need you to do anything
<Sigma88> I can just do this:
<Sigma88> (lets see if I understood it properly)
<Sigma88> something like that^
<Sigma88> ?
<Kopernicus> [Kopernicus] Sigma88 commented on issue #232: @StollD I'll let you merge the PRs from now on :D https://git.io/vdvY3
<Thomas> That would completely kill the original constructor
<Thomas> And it would be silly because we can and should add this to Kopernicus (it is useful)
<Sigma88> yeah of course
<Sigma88> but if you missed one I needed I could always do that
<Thomas> Yes, you could (with some improvements)
GregroxMun has joined #Kopernicus
Raidernick has quit [Read error: Connection reset by peer]
Raidernick has joined #Kopernicus
<Qboid> GregroxMun: Sigma88 left a message for you in #Kopernicus [21.09.2017 13:01:51]: "lol"
<GregroxMun> o/
<Sigma88> 0/
EigenRaptor is now known as UmbralRaptor
egg is now known as egg|zzz|egg