<Sigma88>
we need to add useTheInName = true to Mun and Sun
<Sigma88>
to the templates
<Sigma88>
that's the problem right?
<Thomas>
No, I need to fix the code that resets the display name :D
<Sigma88>
let me check what happens if I add "useTheInName" to Mun
<Sigma88>
btw, all my mods work out of the box
<Sigma88>
which is weird to say the least
<Sigma88>
the only change I needed to make was putting a (Texture2D) cast in front of a texture which I was loading from the list of loading screens
<Sigma88>
because now that array is a Object[] as opposed as a Texture2D[]
<Sigma88>
even tho it contains basically only Texture2Ds
<Sigma88>
thomas, also the cfgs from "Kopernicus/Config" are loading weirdly on windows' notepad because they are formatted for linux
<Sigma88>
not sure if that's intentional
<Thomas>
to hell with windows notepad
<Thomas>
:D
<Sigma88>
I just mentioned because I noticed it always loaded fine untill now
<Thomas>
The config was always formatted for linux
<Sigma88>
really?
<Sigma88>
that's how little I open it then :D
<Thomas>
I remember a post from 2014 complaining about it because it didnt work in windows notepad
<Sigma88>
possibly from me
<Sigma88>
:D
Gameslinx has joined #Kopernicus
<Sigma88>
Thomas: btw, adding useTheInName fixed the mun
<Gameslinx>
o/
<Thomas>
Yeah, but thats not the solution I want
<Thomas>
o/
<Sigma88>
how are you going to approach it?
<Gameslinx>
Quick question about modulemanager configs: If I'm adding an entry to a config using " % ", do I need to add the % for everything inside the node?
<Sigma88>
no
<Gameslinx>
Alright
<Sigma88>
thomas: I mean, since you leave the "useTheInName" option, I would expect cloning the Mun would give the new body the same behaviour,
<Sigma88>
unless you want to deprecate usetheinname in favor of displayname
<Thomas>
Sigma88: Well, the Mun is called "The Mun" when Kopernicus clones it. In the past Kopernicus resetted useTheInName when you changed the name of the body (so bodyname != tempate name). Now it seems to ingnore this and simply resets "useTheInName", so displayName always
<Sigma88>
thomas, what?
<Sigma88>
I distinctly remember inheriting the usetheinname from the template
<Sigma88>
is that another wrong thing I remember?
<Sigma88>
lol
<Thomas>
It only did that for the stock system
<Thomas>
if you changed the name, you lost it
<Sigma88>
no I remember cloning the sun in GN and getting The for all the stars
<Thomas>
At least it was supposed to work like that
<Thomas>
:D
<Sigma88>
weird
<Gameslinx>
Is this valid syntax: "@Kopernicus:AFTER[Kopernicus]:FOR[ModName]
<Sigma88>
no
<Sigma88>
I mean
<Sigma88>
yes but that's not a good idea
<Sigma88>
use
<Sigma88>
@Kopernicus:FOR[ModName]
<Gameslinx>
Ah alright
<Gameslinx>
Thank you
<Sigma88>
you can add :NEEDS[Kopernicus] but it's pointless
<Sigma88>
since if there is no kopernicus it means there is no node to edit
<Kopernicus>
[Kopernicus] Sigma88 pushed 1 new commit to master: https://git.io/vHngN
<Kopernicus>
Kopernicus/master 259ff7d Sigma88: you don't need this ;)
<Kopernicus>
[Kopernicus] Sigma88 pushed 1 new commit to master: https://git.io/vHn2e
<Kopernicus>
Kopernicus/master 1bf2ef0 Sigma88: but you might need this
<Sigma88>
thomas, now that I think about it
<Sigma88>
I would suggest against using MM to patch the solar panels
<Sigma88>
I would make a ConfigNode fixer in the dll
<Sigma88>
there might be part mods that add the solar panel module after kopernicus edits them
<Kopernicus>
[Kopernicus] StollD pushed 1 new commit to master: https://git.io/vHn2f
<Sigma88>
you can remove the first @MODULE if you don't care about case sensitivity
<Kopernicus>
[Kopernicus] StollD pushed 1 new commit to master: https://git.io/vHn2G
<Kopernicus>
Kopernicus/master a61dba4 Dorian Stoll: Config inside of the config
<Sigma88>
there's still a case in which the cfg could cause issues
<Sigma88>
but it's so dumb that I would blame the other modder that set up the system so that this issue can occur
<Sigma88>
(basically, the kopernicus cfg will trigger on MODULES that have "name = ModuleDeployableSolarPanel", even if that is not the first "name" key in the node)
<Sigma88>
so if the first name is different, and the second name is ModuleDeployableSolarPanel, kopernicus will change the first name
<Kopernicus>
[Kopernicus] Sigma88 pushed 1 new commit to master: https://git.io/vHnrm
<Kopernicus>
Kopernicus/master 7f44013 Sigma88: kopernicus' planet color
<Thomas>
Hmm, something is weird about the lights
<Sigma88>
which lights?
<Sigma88>
starlight?
<Thomas>
Starlights yes
<Sigma88>
tell me if I need to test anything
<Thomas>
when I install ohiobobs test config, and cheat a vessel around the sun, I get no light from the sun
<Thomas>
When I orbit TestStar, I get lights
<Sigma88>
did you save/reload?
<Sigma88>
cheating messes up the tracker
<Sigma88>
when you save-reload it should work
<Thomas>
I quicksaved and quickloaded and nothing happened
<Sigma88>
let me check
<Thomas>
Ohh
<Thomas>
I know whats wrong
<Thomas>
I set an orbit around sun, but TestStar caugh my vessel
<Thomas>
.. But sun is still the nearest star
<Thomas>
!slap Starlightswitcher
* Qboid
puts Starlightswitcher as a stamp on his next application letter
<Sigma88>
what?
<Sigma88>
are you pointing to the closest?
<Sigma88>
shouldn't you point to the one with the highest flux?
<Thomas>
No the light is only enabled for the closest star
<Thomas>
I am not talking about flux
<Thomas>
I am talking about light
<Sigma88>
ahhh so the lighting effect?
<Sigma88>
that's a bit more complex as a choice
<Sigma88>
there's still space to argue that the biggest flux should be the one displayed as ambient light
<Sigma88>
but that's your choice
<Sigma88>
Thomas: does your code correctly adjust for eclipses?
<Thomas>
... what?
<Sigma88>
i don't remember, does stock ksp stop solar panels when there's a planet between them and the sun?
<Sigma88>
I would assume so
<Sigma88>
I don't think you get light when behid a planet
<Thomas>
ah, yes
<Sigma88>
so if there are two star, and the best one is temporarily hidden behind a planet, the solar panels will turn to the second star?
<Sigma88>
that would be cool
<Thomas>
yes, they should do that
<Sigma88>
cool
<Sigma88>
and now that I think about it, I think there are two choices when you are considering light
<Sigma88>
the lighting effect I mean
<Sigma88>
1- the star that has the biggest flux (solar panels will point there, so it makes sense that you see them illuminated by that star)
<Sigma88>
2- the star that is illuminating whatever body you are orbiting (that planet will be illuminated by that star, so it makes sense that the craft has the same lighting)
<Sigma88>
unless you are changing lighting for planets as well
<Sigma88>
in which case always #1
<Qboid>
[#1] title: Missing variable in PQSMod_CelestialBodyTransform. | Should have the 'body' var set to the planet's Celestialbody component.... | https://github.com/Kopernicus/Kopernicus/issues/1
<Sigma88>
you silly qboid
<Thomas>
Hmm, I blame the config. The debugger says that the light is enabled
<GregroxMun>
I feel like making a Stock Kerbol Rekerjiggered, just a set of stockalike improvements to the system that doesn't change the overall feel of the system so heavily.
<GregroxMun>
Duna Restoration Project, a new skin for Jool, more realistic atmospheres (visually and otherwise), a Sol-like Sun, and maybe a few more improvements.
<GregroxMun>
Maybe even a couple new bodies.
<GregroxMun>
But without such a huge emphasis on realism.
Galileo88 has joined #Kopernicus
<Sigma88>
Galileo88: you can stay logged in :)
<Galileo88>
Yeah?
<Galileo88>
that would be nice
<GregroxMun>
I think I'm getting tired of RevSSS and how realistic it is. Maybe it's alright if Kerbal planets are really colorful.
<GregroxMun>
But I want to make it look a bit better.
<Galileo88>
Ok i made the changes. Also removed cbNameLater and added displayName in the properties for bodies that needed it. Now I hear the main menu music but all i get is the spinning loading texture
<Sigma88>
output log might have suggestions
<Sigma88>
or kopernicus.log
<KillAshley|SEMI>
check kopernicus.log, see if any body errors
ferram4 has quit [Read error: Connection reset by peer]
ferram4 has joined #Kopernicus
Galileo88 has joined #Kopernicus
<Galileo88>
Hey guys i got it figured out. I reverted all of my changes and started fresh. making the changes one system at a time. Works great. Sorry for fussin' at you guys earlier